Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1644737

Re: [PATCH] Staging: media: fix missing blank line coding style issue in atomisp_tpg.c

Show all headers | View raw

On Wed, 2017-05-17 at 21:48 -0400, Manny Vindiola wrote:
> This is a patch to the atomisp_tpg.c file that fixes up a missing
> blank line warning found by the checkpatch.pl tool
> 
> Signed-off-by: Manny Vindiola <mannyv@gmail.com>
> ---
>  drivers/staging/media/atomisp/pci/atomisp2/atomisp_tpg.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/staging/media/atomisp/pci/atomisp2/atomisp_tpg.c
> b/drivers/staging/media/atomisp/pci/atomisp2/atomisp_tpg.c
> index 996d1bd..48b9604 100644
> --- a/drivers/staging/media/atomisp/pci/atomisp2/atomisp_tpg.c
> +++ b/drivers/staging/media/atomisp/pci/atomisp2/atomisp_tpg.c
> @@ -56,6 +56,7 @@ static int tpg_set_fmt(struct v4l2_subdev *sd,
>  		       struct v4l2_subdev_format *format)
>  {
>  	struct v4l2_mbus_framefmt *fmt = &format->format;
> +
>  	if (format->pad)
>  		return -EINVAL;
>  	/* only raw8 grbg is supported by TPG */

The TODO fille for this driver specifically says not to send formatting
patches at this point.

There is no point making trivial spacing changes in code that needs
lots of real work. It's like polishing your car when the doors have
fallen off.

Alan

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] Staging: media: fix missing blank line coding style issue in atomisp_tpg.c Manny Vindiola <mannyv@gmail.com> - 2017-05-18 03:50 +0200
  Re: [PATCH] Staging: media: fix missing blank line coding style  issue in atomisp_tpg.c Alan Cox <alan@linux.intel.com> - 2017-05-18 18:40 +0200
    Re: [PATCH] Staging: media: fix missing blank line coding style  issue in atomisp_tpg.c Greg KH <gregkh@linuxfoundation.org> - 2017-05-18 22:50 +0200

csiph-web