Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1644430 > unrolled thread
| Started by | srishti <srishtishar@gmail.com> |
|---|---|
| First post | 2017-05-18 14:20 +0200 |
| Last post | 2017-05-19 22:00 +0200 |
| Articles | 6 — 4 participants |
Back to article view | Back to linux.kernel
[PATCH] Staging: bcm2835-audio: bcm2835_ctl.c: Fixed a comment coding style issue srishti <srishtishar@gmail.com> - 2017-05-18 14:20 +0200
Re: [PATCH] Staging: bcm2835-audio: bcm2835_ctl.c: Fixed a comment coding style issue Greg KH <gregkh@linuxfoundation.org> - 2017-05-18 16:00 +0200
Fwd: [PATCH] Staging: bcm2835-audio: bcm2835_ctl.c: Fixed a comment coding style issue srishti sharma <srishtishar@gmail.com> - 2017-05-18 17:50 +0200
Re: [PATCH] Staging: bcm2835-audio: bcm2835_ctl.c: Fixed a comment coding style issue srishti sharma <srishtishar@gmail.com> - 2017-05-19 21:40 +0200
Re: [PATCH] Staging: bcm2835-audio: bcm2835_ctl.c: Fixed a comment coding style issue Dan Carpenter <dan.carpenter@oracle.com> - 2017-05-19 21:40 +0200
Re: [PATCH] Staging: bcm2835-audio: bcm2835_ctl.c: Fixed a comment coding style issue srishti sharma <srishtishar@gmail.com> - 2017-05-19 22:00 +0200
| From | srishti <srishtishar@gmail.com> |
|---|---|
| Date | 2017-05-18 14:20 +0200 |
| Subject | [PATCH] Staging: bcm2835-audio: bcm2835_ctl.c: Fixed a comment coding style issue |
| Message-ID | <tIszo-2pW-33@gated-at.bofh.it> |
From: srishti sharma <srishtishar@gmail.com>
Fixed a trailing */ issue.
Signed-off-by: srishti sharma <srishtishar@gmail.com>
---
drivers/staging/bcm2835-audio/bcm2835-ctl.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/bcm2835-audio/bcm2835-ctl.c b/drivers/staging/bcm2835-audio/bcm2835-ctl.c
index a4ffa1b..38fabab 100644
--- a/drivers/staging/bcm2835-audio/bcm2835-ctl.c
+++ b/drivers/staging/bcm2835-audio/bcm2835-ctl.c
@@ -247,8 +247,8 @@ static int snd_bcm2835_spdif_mask_get(struct snd_kcontrol *kcontrol,
struct snd_ctl_elem_value *ucontrol)
{
/* bcm2835 supports only consumer mode and sets all other format flags
- * automatically. So the only thing left is signalling non-audio
- * content */
+ * automatically. So the only thing left is signalling non-audio content
+ */
ucontrol->value.iec958.status[0] = IEC958_AES0_NONAUDIO;
return 0;
}
2.7.4
[toc] | [next] | [standalone]
| From | Greg KH <gregkh@linuxfoundation.org> |
|---|---|
| Date | 2017-05-18 16:00 +0200 |
| Subject | Re: [PATCH] Staging: bcm2835-audio: bcm2835_ctl.c: Fixed a comment coding style issue |
| Message-ID | <tIu8a-3sl-5@gated-at.bofh.it> |
| In reply to | #1644430 |
On Thu, May 18, 2017 at 04:20:15PM +0530, srishti wrote: > From: srishti sharma <srishtishar@gmail.com> > > Fixed a trailing */ issue. > > Signed-off-by: srishti sharma <srishtishar@gmail.com> > --- > drivers/staging/bcm2835-audio/bcm2835-ctl.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) You sent two copies of this, which am I supposed to apply? And what changed from the last version? I'm dropping this, please fix and only send _one_ copy of the patch. thanks, greg k-h
[toc] | [prev] | [next] | [standalone]
| From | srishti sharma <srishtishar@gmail.com> |
|---|---|
| Date | 2017-05-18 17:50 +0200 |
| Subject | Fwd: [PATCH] Staging: bcm2835-audio: bcm2835_ctl.c: Fixed a comment coding style issue |
| Message-ID | <tIvQB-4Ia-9@gated-at.bofh.it> |
| In reply to | #1644571 |
---------- Forwarded message ---------- From: srishti sharma <srishtishar@gmail.com> Date: Thu, May 18, 2017 at 9:06 PM Subject: Re: [PATCH] Staging: bcm2835-audio: bcm2835_ctl.c: Fixed a comment coding style issue To: Greg KH <gregkh@linuxfoundation.org> On Thu, May 18, 2017 at 7:28 PM, Greg KH <gregkh@linuxfoundation.org> wrote: > On Thu, May 18, 2017 at 04:20:15PM +0530, srishti wrote: >> From: srishti sharma <srishtishar@gmail.com> >> >> Fixed a trailing */ issue. >> >> Signed-off-by: srishti sharma <srishtishar@gmail.com> >> --- >> drivers/staging/bcm2835-audio/bcm2835-ctl.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) > > You sent two copies of this, which am I supposed to apply? And what > changed from the last version? > > I'm dropping this, please fix and only send _one_ copy of the patch. > > thanks, > > greg k-h both the patches are same , the from and signed-off-by didn't have my legal name in the patch that I had sent before these . My "send mail as " settings already have my legal name but it is only accepting the first name . So I edited the from line in the patch itself , if this format is correct do I still need to send another patch ? Please let me know if it is still incorrect . I have also tried sending it with my legal name as an alias name in "send email as" settings , but it only reflects in the from header when I send an email directly from gmail and not when using git send-email and hence two copies got sent , I am sorry about that. Regards, Srishti
[toc] | [prev] | [next] | [standalone]
| From | srishti sharma <srishtishar@gmail.com> |
|---|---|
| Date | 2017-05-19 21:40 +0200 |
| Subject | Re: [PATCH] Staging: bcm2835-audio: bcm2835_ctl.c: Fixed a comment coding style issue |
| Message-ID | <tIVUJ-6R6-1@gated-at.bofh.it> |
| In reply to | #1644571 |
Was the format of this patch acceptable ,the "from" matches the "signed-off-by" right , so this should be correct , were there any errors in this ? Should I resend it ? Regards, Srishti On Thu, May 18, 2017 at 7:28 PM, Greg KH <gregkh@linuxfoundation.org> wrote: > On Thu, May 18, 2017 at 04:20:15PM +0530, srishti wrote: >> From: srishti sharma <srishtishar@gmail.com> >> >> Fixed a trailing */ issue. >> >> Signed-off-by: srishti sharma <srishtishar@gmail.com> >> --- >> drivers/staging/bcm2835-audio/bcm2835-ctl.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) > > You sent two copies of this, which am I supposed to apply? And what > changed from the last version? > > I'm dropping this, please fix and only send _one_ copy of the patch. > > thanks, > > greg k-h
[toc] | [prev] | [next] | [standalone]
| From | Dan Carpenter <dan.carpenter@oracle.com> |
|---|---|
| Date | 2017-05-19 21:40 +0200 |
| Subject | Re: [PATCH] Staging: bcm2835-audio: bcm2835_ctl.c: Fixed a comment coding style issue |
| Message-ID | <tIVUK-6R6-19@gated-at.bofh.it> |
| In reply to | #1645863 |
On Sat, May 20, 2017 at 01:00:17AM +0530, srishti sharma wrote: > Was the format of this patch acceptable ,the "from" matches the > "signed-off-by" right , so this should be correct , were there any > errors in this ? Should I resend it ? > > Regards, > Srishti > You should capitalize your name in both since you're doing that here. Also I really think you can figure out how to fix your email headers so you don't need to use a From header. Lots of people use gmail and they were able to figure it out. But yeah, the way you sent it is also fine. regards, dan carpenter
[toc] | [prev] | [next] | [standalone]
| From | srishti sharma <srishtishar@gmail.com> |
|---|---|
| Date | 2017-05-19 22:00 +0200 |
| Subject | Re: [PATCH] Staging: bcm2835-audio: bcm2835_ctl.c: Fixed a comment coding style issue |
| Message-ID | <tIWe6-6Zg-17@gated-at.bofh.it> |
| In reply to | #1645870 |
On Sat, May 20, 2017 at 1:03 AM, Dan Carpenter <dan.carpenter@oracle.com> wrote: > On Sat, May 20, 2017 at 01:00:17AM +0530, srishti sharma wrote: >> Was the format of this patch acceptable ,the "from" matches the >> "signed-off-by" right , so this should be correct , were there any >> errors in this ? Should I resend it ? >> >> Regards, >> Srishti >> > > You should capitalize your name in both since you're doing that here. > > Also I really think you can figure out how to fix your email headers so > you don't need to use a From header. Lots of people use gmail and they > were able to figure it out. > > But yeah, the way you sent it is also fine. > > regards, > dan carpenter > Okay , Thanks a lot !
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web