Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1645870

Re: [PATCH] Staging: bcm2835-audio: bcm2835_ctl.c: Fixed a comment coding style issue

From Dan Carpenter <dan.carpenter@oracle.com>
Newsgroups linux.kernel
Subject Re: [PATCH] Staging: bcm2835-audio: bcm2835_ctl.c: Fixed a comment coding style issue
Date 2017-05-19 21:40 +0200
Message-ID <tIVUK-6R6-19@gated-at.bofh.it> (permalink)
References <tIszo-2pW-33@gated-at.bofh.it> <tIu8a-3sl-5@gated-at.bofh.it> <tIVUJ-6R6-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Sat, May 20, 2017 at 01:00:17AM +0530, srishti sharma wrote:
> Was the format of this patch acceptable ,the "from" matches the
> "signed-off-by" right , so this should be correct , were there any
> errors in this ? Should I resend it ?
> 
> Regards,
> Srishti
> 

You should capitalize your name in both since you're doing that here.

Also I really think you can figure out how to fix your email headers so
you don't need to use a From header.  Lots of people use gmail and they
were able to figure it out.

But yeah, the way you sent it is also fine.

regards,
dan carpenter

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] Staging: bcm2835-audio: bcm2835_ctl.c: Fixed a comment coding style issue srishti <srishtishar@gmail.com> - 2017-05-18 14:20 +0200
  Re: [PATCH] Staging: bcm2835-audio: bcm2835_ctl.c: Fixed a comment  coding style issue Greg KH <gregkh@linuxfoundation.org> - 2017-05-18 16:00 +0200
    Fwd: [PATCH] Staging: bcm2835-audio: bcm2835_ctl.c: Fixed a comment  coding style issue srishti sharma <srishtishar@gmail.com> - 2017-05-18 17:50 +0200
    Re: [PATCH] Staging: bcm2835-audio: bcm2835_ctl.c: Fixed a comment  coding style issue srishti sharma <srishtishar@gmail.com> - 2017-05-19 21:40 +0200
      Re: [PATCH] Staging: bcm2835-audio: bcm2835_ctl.c: Fixed a comment  coding style issue Dan Carpenter <dan.carpenter@oracle.com> - 2017-05-19 21:40 +0200
        Re: [PATCH] Staging: bcm2835-audio: bcm2835_ctl.c: Fixed a comment  coding style issue srishti sharma <srishtishar@gmail.com> - 2017-05-19 22:00 +0200

csiph-web