Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1645963 > unrolled thread

[PATCH 2/5] fork,random: use get_random_canary to set tsk->stack_canary

Started byriel@redhat.com
First post2017-05-19 23:40 +0200
Last post2017-05-19 23:40 +0200
Articles 1 — 1 participant

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  [PATCH 2/5] fork,random: use get_random_canary to set tsk->stack_canary riel@redhat.com - 2017-05-19 23:40 +0200

#1645963 — [PATCH 2/5] fork,random: use get_random_canary to set tsk->stack_canary

Fromriel@redhat.com
Date2017-05-19 23:40 +0200
Subject[PATCH 2/5] fork,random: use get_random_canary to set tsk->stack_canary
Message-ID<tIXMR-86v-3@gated-at.bofh.it>
From: Rik van Riel <riel@redhat.com>

Use the ascii-armor canary to prevent unterminated C string overflows
from being able to successfully overwrite the canary, even if they
somehow obtain the canary value.

Inspired by execshield ascii-armor and PaX/grsecurity.

Signed-off-by: Rik van Riel <riel@redhat.com>
---
 kernel/fork.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/fork.c b/kernel/fork.c
index aa1076c5e4a9..b3591e9250a8 100644
--- a/kernel/fork.c
+++ b/kernel/fork.c
@@ -560,7 +560,7 @@ static struct task_struct *dup_task_struct(struct task_struct *orig, int node)
 	set_task_stack_end_magic(tsk);
 
 #ifdef CONFIG_CC_STACKPROTECTOR
-	tsk->stack_canary = get_random_long();
+	tsk->stack_canary = get_random_canary();
 #endif
 
 	/*
-- 
2.9.3

[toc] | [standalone]


Back to top | Article view | linux.kernel


csiph-web