Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1643300 > unrolled thread

Re: [PATCH] powerpc/sequoia: fix NAND partitions not to overlap

Started byPavel Machek <pavel@denx.de>
First post2017-05-17 14:10 +0200
Last post2017-05-22 11:20 +0200
Articles 8 — 3 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH] powerpc/sequoia: fix NAND partitions not to overlap Pavel Machek <pavel@denx.de> - 2017-05-17 14:10 +0200
    Re: [PATCH] powerpc/sequoia: fix NAND partitions not to overlap Andrew Morton <akpm@linux-foundation.org> - 2017-05-17 23:40 +0200
      Re: [PATCH] powerpc/sequoia: fix NAND partitions not to overlap Pavel Machek <pavel@denx.de> - 2017-05-18 11:50 +0200
        Re: [PATCH] powerpc/sequoia: fix NAND partitions not to overlap Michael Ellerman <mpe@ellerman.id.au> - 2017-05-19 08:00 +0200
          Re: [PATCH] powerpc/sequoia: fix NAND partitions not to overlap Pavel Machek <pavel@denx.de> - 2017-05-19 11:20 +0200
          Re: [PATCH] powerpc/sequoia: fix NAND partitions not to overlap Michael Ellerman <mpe@ellerman.id.au> - 2017-05-19 12:10 +0200
            Re: [PATCH] powerpc/sequoia: fix NAND partitions not to overlap Pavel Machek <pavel@denx.de> - 2017-05-19 13:20 +0200
              Re: [PATCH] powerpc/sequoia: fix NAND partitions not to overlap Michael Ellerman <mpe@ellerman.id.au> - 2017-05-22 11:20 +0200

#1643300 — Re: [PATCH] powerpc/sequoia: fix NAND partitions not to overlap

FromPavel Machek <pavel@denx.de>
Date2017-05-17 14:10 +0200
SubjectRe: [PATCH] powerpc/sequoia: fix NAND partitions not to overlap
Message-ID<tI5Wa-2Uc-3@gated-at.bofh.it>

[Multipart message — attachments visible in raw view] — view raw

On Sun 2017-04-02 12:05:36, Pavel Machek wrote:
> Fix overlapping NAND partitions.
> 
> Signed-off-by: Pavel Machek <pavel@ucw.cz>

Ping? Two partitions at same place are bad news...
									Pavel

> diff --git a/arch/powerpc/boot/dts/sequoia.dts b/arch/powerpc/boot/dts/sequoia.dts
> index b1d3292..e41b88a 100644
> --- a/arch/powerpc/boot/dts/sequoia.dts
> +++ b/arch/powerpc/boot/dts/sequoia.dts
> @@ -229,7 +229,7 @@
>  						};
>  						partition@84000 {
>  							label = "user";
> -							reg = <0x00000000 0x01f7c000>;
> +							reg = <0x00084000 0x01f7c000>;
>  						};
>  					};
>  				};
> 
> 
> 



-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[toc] | [next] | [standalone]

#1643640

FromAndrew Morton <akpm@linux-foundation.org>
Date2017-05-17 23:40 +0200
Message-ID<tIePL-8wt-1@gated-at.bofh.it>
In reply to#1643300
On Wed, 17 May 2017 14:06:13 +0200 Pavel Machek <pavel@denx.de> wrote:

> On Sun 2017-04-02 12:05:36, Pavel Machek wrote:
> > Fix overlapping NAND partitions.
> > 
> > Signed-off-by: Pavel Machek <pavel@ucw.cz>
> 
> Ping? Two partitions at same place are bad news...

Please expand on "bad news"?  What are the runtime effects of this
change?  Decisions about which kernel(s) to patch depend on this info.

[toc] | [prev] | [next] | [standalone]

#1644023

FromPavel Machek <pavel@denx.de>
Date2017-05-18 11:50 +0200
Message-ID<tIqee-aM-11@gated-at.bofh.it>
In reply to#1643640

[Multipart message — attachments visible in raw view] — view raw

On Wed 2017-05-17 14:37:17, Andrew Morton wrote:
> On Wed, 17 May 2017 14:06:13 +0200 Pavel Machek <pavel@denx.de> wrote:
> 
> > On Sun 2017-04-02 12:05:36, Pavel Machek wrote:
> > > Fix overlapping NAND partitions.
> > > 
> > > Signed-off-by: Pavel Machek <pavel@ucw.cz>
> > 
> > Ping? Two partitions at same place are bad news...
> 
> Please expand on "bad news"?  What are the runtime effects of this
> change?  Decisions about which kernel(s) to patch depend on this info.

Well... two partitions at same place. If you use one, you will corrupt
information on the other one.

OTOH this moves partition around (so that they don't overlap) so it is
probably not stable candidate.

I guess this is not huge issue; people using these boards probably
have custom dts changes, anyway...

Best regards,

									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[toc] | [prev] | [next] | [standalone]

#1645212

FromMichael Ellerman <mpe@ellerman.id.au>
Date2017-05-19 08:00 +0200
Message-ID<tIJ7c-6aa-5@gated-at.bofh.it>
In reply to#1644023
Pavel Machek <pavel@denx.de> writes:

> On Wed 2017-05-17 14:37:17, Andrew Morton wrote:
>> On Wed, 17 May 2017 14:06:13 +0200 Pavel Machek <pavel@denx.de> wrote:
>> 
>> > On Sun 2017-04-02 12:05:36, Pavel Machek wrote:
>> > > Fix overlapping NAND partitions.
>> > > 
>> > > Signed-off-by: Pavel Machek <pavel@ucw.cz>
>> > 
>> > Ping? Two partitions at same place are bad news...
>> 
>> Please expand on "bad news"?  What are the runtime effects of this
>> change?  Decisions about which kernel(s) to patch depend on this info.
>
> Well... two partitions at same place. If you use one, you will corrupt
> information on the other one.
>
> OTOH this moves partition around (so that they don't overlap) so it is
> probably not stable candidate.
>
> I guess this is not huge issue; people using these boards probably
> have custom dts changes, anyway...

Or no one's even using it anymore.

I can take this via powerpc, I won't mark it for stable etc.

cheers

[toc] | [prev] | [next] | [standalone]

#1645450

FromPavel Machek <pavel@denx.de>
Date2017-05-19 11:20 +0200
Message-ID<tIMeK-8ro-9@gated-at.bofh.it>
In reply to#1645212

[Multipart message — attachments visible in raw view] — view raw

Hi!

> > Well... two partitions at same place. If you use one, you will corrupt
> > information on the other one.
> >
> > OTOH this moves partition around (so that they don't overlap) so it is
> > probably not stable candidate.
> >
> > I guess this is not huge issue; people using these boards probably
> > have custom dts changes, anyway...
> 
> Or no one's even using it anymore.
> 
> I can take this via powerpc, I won't mark it for stable etc.

That sounds good.

Thanks,
								Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[toc] | [prev] | [next] | [standalone]

#1645485

FromMichael Ellerman <mpe@ellerman.id.au>
Date2017-05-19 12:10 +0200
Message-ID<tIN17-GC-1@gated-at.bofh.it>
In reply to#1645212
Michael Ellerman <mpe@ellerman.id.au> writes:

> Pavel Machek <pavel@denx.de> writes:
>
>> On Wed 2017-05-17 14:37:17, Andrew Morton wrote:
>>> On Wed, 17 May 2017 14:06:13 +0200 Pavel Machek <pavel@denx.de> wrote:
>>> 
>>> > On Sun 2017-04-02 12:05:36, Pavel Machek wrote:
>>> > > Fix overlapping NAND partitions.
>>> > > 
>>> > > Signed-off-by: Pavel Machek <pavel@ucw.cz>
>>> > 
>>> > Ping? Two partitions at same place are bad news...
>>> 
>>> Please expand on "bad news"?  What are the runtime effects of this
>>> change?  Decisions about which kernel(s) to patch depend on this info.
>>
>> Well... two partitions at same place. If you use one, you will corrupt
>> information on the other one.
>>
>> OTOH this moves partition around (so that they don't overlap) so it is
>> probably not stable candidate.
>>
>> I guess this is not huge issue; people using these boards probably
>> have custom dts changes, anyway...
>
> Or no one's even using it anymore.
>
> I can take this via powerpc, I won't mark it for stable etc.

It became:

    Author:     Pavel Machek <pavel@denx.de>

    powerpc/sequoia: Fix NAND partitions not to overlap
    
    Currently the DTS defines two partitions at the same addresses, if you
    use one, you will corrupt information on the other one. Fix it by
    shifting the second partition.
    
    Signed-off-by: Pavel Machek <pavel@ucw.cz>
    [mpe: Reconstruct change log from email thread]
    Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>


Minor nit, your From: address doesn't match your Signed-off-by: address,
which trips my "check patch is signed-off-by author" script. I can
just ignore it, but I think it's preferable if they match.

cheers

[toc] | [prev] | [next] | [standalone]

#1645522

FromPavel Machek <pavel@denx.de>
Date2017-05-19 13:20 +0200
Message-ID<tIO6R-1nG-13@gated-at.bofh.it>
In reply to#1645485

[Multipart message — attachments visible in raw view] — view raw

Hi!

> >>> > > Signed-off-by: Pavel Machek <pavel@ucw.cz>
> >>> > 
> >>> > Ping? Two partitions at same place are bad news...
> >>> 
> >>> Please expand on "bad news"?  What are the runtime effects of this
> >>> change?  Decisions about which kernel(s) to patch depend on this info.
> >>
> >> Well... two partitions at same place. If you use one, you will corrupt
> >> information on the other one.
> >>
> >> OTOH this moves partition around (so that they don't overlap) so it is
> >> probably not stable candidate.
> >>
> >> I guess this is not huge issue; people using these boards probably
> >> have custom dts changes, anyway...
> >
> > Or no one's even using it anymore.
> >
> > I can take this via powerpc, I won't mark it for stable etc.
> 
> It became:
> 
>     Author:     Pavel Machek <pavel@denx.de>
> 
>     powerpc/sequoia: Fix NAND partitions not to overlap
>     
>     Currently the DTS defines two partitions at the same addresses, if you
>     use one, you will corrupt information on the other one. Fix it by
>     shifting the second partition.
>     
>     Signed-off-by: Pavel Machek <pavel@ucw.cz>
>     [mpe: Reconstruct change log from email thread]
>     Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
> 
> 
> Minor nit, your From: address doesn't match your Signed-off-by: address,
> which trips my "check patch is signed-off-by author" script. I can
> just ignore it, but I think it's preferable if they match.

Sorry about that (I have automatic scripts changing From:). It is
still me, but I guess denx should get the credit here, so you can use.

Signed-off-by: Pavel Machek <pavel@denx.de>

Thanks,
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[toc] | [prev] | [next] | [standalone]

#1646643

FromMichael Ellerman <mpe@ellerman.id.au>
Date2017-05-22 11:20 +0200
Message-ID<tJRFo-3IZ-29@gated-at.bofh.it>
In reply to#1645522
Pavel Machek <pavel@denx.de> writes:

> Hi!
>
>> >>> > > Signed-off-by: Pavel Machek <pavel@ucw.cz>
>> >>> > 
>> >>> > Ping? Two partitions at same place are bad news...
>> >>> 
>> >>> Please expand on "bad news"?  What are the runtime effects of this
>> >>> change?  Decisions about which kernel(s) to patch depend on this info.
>> >>
>> >> Well... two partitions at same place. If you use one, you will corrupt
>> >> information on the other one.
>> >>
>> >> OTOH this moves partition around (so that they don't overlap) so it is
>> >> probably not stable candidate.
>> >>
>> >> I guess this is not huge issue; people using these boards probably
>> >> have custom dts changes, anyway...
>> >
>> > Or no one's even using it anymore.
>> >
>> > I can take this via powerpc, I won't mark it for stable etc.
>> 
>> It became:
>> 
>>     Author:     Pavel Machek <pavel@denx.de>
>> 
>>     powerpc/sequoia: Fix NAND partitions not to overlap
>>     
>>     Currently the DTS defines two partitions at the same addresses, if you
>>     use one, you will corrupt information on the other one. Fix it by
>>     shifting the second partition.
>>     
>>     Signed-off-by: Pavel Machek <pavel@ucw.cz>
>>     [mpe: Reconstruct change log from email thread]
>>     Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
>> 
>> 
>> Minor nit, your From: address doesn't match your Signed-off-by: address,
>> which trips my "check patch is signed-off-by author" script. I can
>> just ignore it, but I think it's preferable if they match.
>
> Sorry about that (I have automatic scripts changing From:). It is
> still me, but I guess denx should get the credit here, so you can use.
>
> Signed-off-by: Pavel Machek <pavel@denx.de>

Sure, done.

cheers

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web