Re: [PATCH] powerpc/sequoia: fix NAND partitions not to overlap

From	Michael Ellerman <mpe@ellerman.id.au>
Newsgroups	linux.kernel
Subject	Re: [PATCH] powerpc/sequoia: fix NAND partitions not to overlap
Date	2017-05-22 11:20 +0200
Message-ID	<tJRFo-3IZ-29@gated-at.bofh.it> (permalink)
References	(2 earlier) <tIePL-8wt-1@gated-at.bofh.it> <tIqee-aM-11@gated-at.bofh.it> <tIJ7c-6aa-5@gated-at.bofh.it> <tIN17-GC-1@gated-at.bofh.it> <tIO6R-1nG-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Pavel Machek <pavel@denx.de> writes:

> Hi!
>
>> >>> > > Signed-off-by: Pavel Machek <pavel@ucw.cz>
>> >>> > 
>> >>> > Ping? Two partitions at same place are bad news...
>> >>> 
>> >>> Please expand on "bad news"?  What are the runtime effects of this
>> >>> change?  Decisions about which kernel(s) to patch depend on this info.
>> >>
>> >> Well... two partitions at same place. If you use one, you will corrupt
>> >> information on the other one.
>> >>
>> >> OTOH this moves partition around (so that they don't overlap) so it is
>> >> probably not stable candidate.
>> >>
>> >> I guess this is not huge issue; people using these boards probably
>> >> have custom dts changes, anyway...
>> >
>> > Or no one's even using it anymore.
>> >
>> > I can take this via powerpc, I won't mark it for stable etc.
>> 
>> It became:
>> 
>>     Author:     Pavel Machek <pavel@denx.de>
>> 
>>     powerpc/sequoia: Fix NAND partitions not to overlap
>>     
>>     Currently the DTS defines two partitions at the same addresses, if you
>>     use one, you will corrupt information on the other one. Fix it by
>>     shifting the second partition.
>>     
>>     Signed-off-by: Pavel Machek <pavel@ucw.cz>
>>     [mpe: Reconstruct change log from email thread]
>>     Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
>> 
>> 
>> Minor nit, your From: address doesn't match your Signed-off-by: address,
>> which trips my "check patch is signed-off-by author" script. I can
>> just ignore it, but I think it's preferable if they match.
>
> Sorry about that (I have automatic scripts changing From:). It is
> still me, but I guess denx should get the credit here, so you can use.
>
> Signed-off-by: Pavel Machek <pavel@denx.de>

Sure, done.

cheers

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH] powerpc/sequoia: fix NAND partitions not to overlap Pavel Machek <pavel@denx.de> - 2017-05-17 14:10 +0200
  Re: [PATCH] powerpc/sequoia: fix NAND partitions not to overlap Andrew Morton <akpm@linux-foundation.org> - 2017-05-17 23:40 +0200
    Re: [PATCH] powerpc/sequoia: fix NAND partitions not to overlap Pavel Machek <pavel@denx.de> - 2017-05-18 11:50 +0200
      Re: [PATCH] powerpc/sequoia: fix NAND partitions not to overlap Michael Ellerman <mpe@ellerman.id.au> - 2017-05-19 08:00 +0200
        Re: [PATCH] powerpc/sequoia: fix NAND partitions not to overlap Pavel Machek <pavel@denx.de> - 2017-05-19 11:20 +0200
        Re: [PATCH] powerpc/sequoia: fix NAND partitions not to overlap Michael Ellerman <mpe@ellerman.id.au> - 2017-05-19 12:10 +0200
          Re: [PATCH] powerpc/sequoia: fix NAND partitions not to overlap Pavel Machek <pavel@denx.de> - 2017-05-19 13:20 +0200
            Re: [PATCH] powerpc/sequoia: fix NAND partitions not to overlap Michael Ellerman <mpe@ellerman.id.au> - 2017-05-22 11:20 +0200

csiph-web