Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1643344 > unrolled thread

Re: [PATCH] iommu/mediatek: include linux/dma-mapping.h

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH] iommu/mediatek: include linux/dma-mapping.h Joerg Roedel <joro@8bytes.org> - 2017-05-17 15:00 +0200

#1643344 — Re: [PATCH] iommu/mediatek: include linux/dma-mapping.h

On Thu, May 11, 2017 at 01:35:51PM +0200, Arnd Bergmann wrote:
> The mediatek iommu driver relied on an implicit include of dma-mapping.h,
> but for some reason that is no longer there in 4.12-rc1:
> 
> drivers/iommu/mtk_iommu_v1.c: In function 'mtk_iommu_domain_finalise':
> drivers/iommu/mtk_iommu_v1.c:233:16: error: implicit declaration of function 'dma_zalloc_coherent'; did you mean 'debug_dma_alloc_coherent'? [-Werror=implicit-function-declaration]
> drivers/iommu/mtk_iommu_v1.c: In function 'mtk_iommu_domain_free':
> drivers/iommu/mtk_iommu_v1.c:265:2: error: implicit declaration of function 'dma_free_coherent'; did you mean 'debug_dma_free_coherent'? [-Werror=implicit-function-declaration]
> 
> This adds an explicit #include to make it build again.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Applied to iommu/fixes, thanks Arnd.

This was probably another victim of 

	208480b iommu: Remove trace-events include from iommu.h

[toc] | [standalone]

Back to top | Article view | linux.kernel

csiph-web