Re: [PATCH] iommu/mediatek: include linux/dma-mapping.h

From	Joerg Roedel <joro@8bytes.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] iommu/mediatek: include linux/dma-mapping.h
Date	2017-05-17 15:00 +0200
Message-ID	<tI6Ix-3ck-13@gated-at.bofh.it> (permalink)
References	<tFUBP-5JW-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, May 11, 2017 at 01:35:51PM +0200, Arnd Bergmann wrote:
> The mediatek iommu driver relied on an implicit include of dma-mapping.h,
> but for some reason that is no longer there in 4.12-rc1:
> 
> drivers/iommu/mtk_iommu_v1.c: In function 'mtk_iommu_domain_finalise':
> drivers/iommu/mtk_iommu_v1.c:233:16: error: implicit declaration of function 'dma_zalloc_coherent'; did you mean 'debug_dma_alloc_coherent'? [-Werror=implicit-function-declaration]
> drivers/iommu/mtk_iommu_v1.c: In function 'mtk_iommu_domain_free':
> drivers/iommu/mtk_iommu_v1.c:265:2: error: implicit declaration of function 'dma_free_coherent'; did you mean 'debug_dma_free_coherent'? [-Werror=implicit-function-declaration]
> 
> This adds an explicit #include to make it build again.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Applied to iommu/fixes, thanks Arnd.

This was probably another victim of 

	208480b iommu: Remove trace-events include from iommu.h

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] iommu/mediatek: include linux/dma-mapping.h Joerg Roedel <joro@8bytes.org> - 2017-05-17 15:00 +0200

csiph-web