Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1641341 > unrolled thread

Re: [PATCH 6/9] regulator: palmas: Drop unnecessary static

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH 6/9] regulator: palmas: Drop unnecessary static Mark Brown <broonie@kernel.org> - 2017-05-15 10:00 +0200
    Re: [PATCH 6/9] regulator: palmas: Drop unnecessary static Julia Lawall <julia.lawall@lip6.fr> - 2017-05-15 12:50 +0200
      Re: [PATCH 6/9] regulator: palmas: Drop unnecessary static Mark Brown <broonie@kernel.org> - 2017-05-15 13:00 +0200

#1641341 — Re: [PATCH 6/9] regulator: palmas: Drop unnecessary static

[Multipart message — attachments visible in raw view] — view raw

On Thu, May 04, 2017 at 10:10:51PM +0200, Julia Lawall wrote:
> Drop static on a local variable, when the variable is initialized before
> any use, on every possible execution path through the function.

When sending a bunch of changes like this please either send the cover
letter to everyone or send each patch separately (this seems like it
stands alone just fine).  The first question when only one patch in a
series is visible is always what are the interdependencies.

[toc] | [next] | [standalone]

#1641527

On Sun, 14 May 2017, Mark Brown wrote:

> On Thu, May 04, 2017 at 10:10:51PM +0200, Julia Lawall wrote:
> > Drop static on a local variable, when the variable is initialized before
> > any use, on every possible execution path through the function.
>
> When sending a bunch of changes like this please either send the cover
> letter to everyone or send each patch separately (this seems like it
> stands alone just fine).  The first question when only one patch in a
> series is visible is always what are the interdependencies.

Not sure what is best to do.  If the cover letter goes to everyone, it
could be rejected for too many recipients.  Currently it goes to all the
mailing lists.  If the patches are sent separately, then could there be a
cover letter for each one?  If the semantic patch is complicated, then I
typically put the whole thing there, and an abbreviated one in the actual
patch.  That is not relevant here, because the semantic patch is small.
Part of the purpose of the cover letter was to allow people who were not
interested to skip over the whole thing at once.

julia

[toc] | [prev] | [next] | [standalone]

#1641537

[Multipart message — attachments visible in raw view] — view raw

On Mon, May 15, 2017 at 06:41:41PM +0800, Julia Lawall wrote:

> mailing lists.  If the patches are sent separately, then could there be a
> cover letter for each one?  If the semantic patch is complicated, then I
> typically put the whole thing there, and an abbreviated one in the actual
> patch.  That is not relevant here, because the semantic patch is small.

Well, if the cover letter is needed to understand the patch then it
needs to go to everyone anyway...

> Part of the purpose of the cover letter was to allow people who were not
> interested to skip over the whole thing at once.

On the flip side things that lack context can get discarded easily.

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web