Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1642904 > unrolled thread
| Started by | Stephen Rothwell <sfr@canb.auug.org.au> |
|---|---|
| First post | 2017-05-17 02:30 +0200 |
| Last post | 2017-05-17 07:10 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
linux-next: build warning after merge of the overlayfs tree Stephen Rothwell <sfr@canb.auug.org.au> - 2017-05-17 02:30 +0200
Re: linux-next: build warning after merge of the overlayfs tree Amir Goldstein <amir73il@gmail.com> - 2017-05-17 07:10 +0200
| From | Stephen Rothwell <sfr@canb.auug.org.au> |
|---|---|
| Date | 2017-05-17 02:30 +0200 |
| Subject | linux-next: build warning after merge of the overlayfs tree |
| Message-ID | <tHV0K-4jx-9@gated-at.bofh.it> |
Hi Miklos,
After merging the overlayfs tree, today's linux-next build (powerpc
ppc64_defconfig) produced this warning:
fs/overlayfs/dir.c: In function 'ovl_rename':
fs/overlayfs/dir.c:1060:2: warning: 'newdentry' may be used uninitialized in this function [-Wmaybe-uninitialized]
dput(newdentry);
^
fs/overlayfs/dir.c:1062:2: warning: 'olddentry' may be used uninitialized in this function [-Wmaybe-uninitialized]
dput(olddentry);
^
Introduced by commit
02cac3227a28 ("ovl: mark upper dir with type origin entries "impure"")
--
Cheers,
Stephen Rothwell
[toc] | [next] | [standalone]
| From | Amir Goldstein <amir73il@gmail.com> |
|---|---|
| Date | 2017-05-17 07:10 +0200 |
| Message-ID | <tHZnI-7gf-7@gated-at.bofh.it> |
| In reply to | #1642904 |
On Wed, May 17, 2017 at 3:19 AM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Hi Miklos,
>
> After merging the overlayfs tree, today's linux-next build (powerpc
> ppc64_defconfig) produced this warning:
>
> fs/overlayfs/dir.c: In function 'ovl_rename':
> fs/overlayfs/dir.c:1060:2: warning: 'newdentry' may be used uninitialized in this function [-Wmaybe-uninitialized]
> dput(newdentry);
> ^
> fs/overlayfs/dir.c:1062:2: warning: 'olddentry' may be used uninitialized in this function [-Wmaybe-uninitialized]
> dput(olddentry);
> ^
>
> Introduced by commit
>
> 02cac3227a28 ("ovl: mark upper dir with type origin entries "impure"")
>
Posted a fix for that ("ovl: fix wrong error handling of ovl_set_impure()")
Thanks!
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web