Re: linux-next: build warning after merge of the overlayfs tree

From	Amir Goldstein <amir73il@gmail.com>
Newsgroups	linux.kernel
Subject	Re: linux-next: build warning after merge of the overlayfs tree
Date	2017-05-17 07:10 +0200
Message-ID	<tHZnI-7gf-7@gated-at.bofh.it> (permalink)
References	<tHV0K-4jx-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, May 17, 2017 at 3:19 AM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Hi Miklos,
>
> After merging the overlayfs tree, today's linux-next build (powerpc
> ppc64_defconfig) produced this warning:
>
> fs/overlayfs/dir.c: In function 'ovl_rename':
> fs/overlayfs/dir.c:1060:2: warning: 'newdentry' may be used uninitialized in this function [-Wmaybe-uninitialized]
>   dput(newdentry);
>   ^
> fs/overlayfs/dir.c:1062:2: warning: 'olddentry' may be used uninitialized in this function [-Wmaybe-uninitialized]
>   dput(olddentry);
>   ^
>
> Introduced by commit
>
>   02cac3227a28 ("ovl: mark upper dir with type origin entries "impure"")
>

Posted a fix for that ("ovl: fix wrong error handling of ovl_set_impure()")

Thanks!

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

linux-next: build warning after merge of the overlayfs tree Stephen Rothwell <sfr@canb.auug.org.au> - 2017-05-17 02:30 +0200
  Re: linux-next: build warning after merge of the overlayfs tree Amir Goldstein <amir73il@gmail.com> - 2017-05-17 07:10 +0200

csiph-web