Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1642125 > unrolled thread

[PATCH 1/2] arm64: marvell: dts: fill MachiatoBin board description

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [PATCH 1/2] arm64: marvell: dts: fill MachiatoBin board description Marcin Wojtas <mw@semihalf.com> - 2017-05-16 01:30 +0200
    Re: [PATCH 1/2] arm64: marvell: dts: fill MachiatoBin board  description Russell King - ARM Linux <linux@armlinux.org.uk> - 2017-05-16 13:20 +0200
    Re: [PATCH 1/2] arm64: marvell: dts: fill MachiatoBin board  description Thomas Petazzoni <thomas.petazzoni@free-electrons.com> - 2017-05-16 14:40 +0200
      Re: [PATCH 1/2] arm64: marvell: dts: fill MachiatoBin board  description Russell King - ARM Linux <linux@armlinux.org.uk> - 2017-05-16 14:50 +0200

#1642125 — [PATCH 1/2] arm64: marvell: dts: fill MachiatoBin board description

This patch adds following improvements to Armada 8040
MachiatoBin:
 * Add 'chosen' node with stdout-path assignment
 * Enable 1G sgmii port
 * Enable SDHCI controllers on AP and CP HW blocks

Signed-off-by: Marcin Wojtas <mw@semihalf.com>
---
 arch/arm64/boot/dts/marvell/armada-8040-mcbin.dts | 34 +++++++++++++++++++++++
 1 file changed, 34 insertions(+)

diff --git a/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dts b/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dts
index f7bb0cc..19d395b 100644
--- a/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dts
+++ b/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dts
@@ -51,6 +51,10 @@
 	compatible = "marvell,armada8040-mcbin", "marvell,armada8040",
 			"marvell,armada-ap806-quad", "marvell,armada-ap806";
 
+	chosen {
+		stdout-path = "serial0:115200n8";
+	};
+
 	memory@00000000 {
 		device_type = "memory";
 		reg = <0x0 0x0 0x0 0x80000000>;
@@ -136,3 +140,33 @@
 	usb-phy = <&usb3h0_phy>;
 	status = "okay";
 };
+
+&cpm_mdio {
+	phy0: ethernet-phy@0 {
+		reg = <0>;
+	};
+};
+
+&cps_ethernet {
+	status = "okay";
+};
+
+&cps_eth1 {
+	status = "okay";
+	phy = <&phy0>;
+	phy-mode = "sgmii";
+};
+
+&ap_sdhci0 {
+	status = "okay";
+	bus-width = <8>;
+	no-1-8-v;
+	non-removable;
+};
+
+&cpm_sdhci0 {
+	status = "okay";
+	bus-width = <4>;
+	no-1-8-v;
+	non-removable;
+};
-- 
1.8.3.1

[toc] | [next] | [standalone]

#1642422 — Re: [PATCH 1/2] arm64: marvell: dts: fill MachiatoBin board description

On Tue, May 16, 2017 at 01:28:32AM +0200, Marcin Wojtas wrote:
> +&cpm_sdhci0 {
> +	status = "okay";
> +	bus-width = <4>;
> +	no-1-8-v;
> +	non-removable;
> +};

Testing the latest free-electrons sdhci driver (that was merged in 4.12-rc1)
_fails_ on mcbin, with it spewing:

mmc1: Timeout waiting for hardware cmd interrupt.
mmc1: sdhci: ============ SDHCI REGISTER DUMP ===========
mmc1: sdhci: Sys addr:  0x00000000 | Version:  0x00000002
mmc1: sdhci: Blk size:  0x00000000 | Blk cnt:  0x00000000
mmc1: sdhci: Argument:  0x00000000 | Trn mode: 0x00000000
mmc1: sdhci: Present:   0x01ff0000 | Host ctl: 0x00000001
mmc1: sdhci: Power:     0x0000000f | Blk gap:  0x00000000
mmc1: sdhci: Wake-up:   0x00000000 | Clock:    0x00003947
mmc1: sdhci: Timeout:   0x00000000 | Int stat: 0x00018000
mmc1: sdhci: Int enab:  0x00ff0003 | Sig enab: 0x00ff0003
mmc1: sdhci: AC12 err:  0x00000000 | Slot int: 0x00000001
mmc1: sdhci: Caps:      0x35ee0099 | Caps_1:   0x0000af77
mmc1: sdhci: Cmd:       0x00000000 | Max curr: 0x00000000
mmc1: sdhci: Resp[0]:   0x00000000 | Resp[1]:  0x00000000
mmc1: sdhci: Resp[2]:   0x00000000 | Resp[3]:  0x00000000
mmc1: sdhci: Host ctl2: 0x00000000
mmc1: sdhci: ADMA Err:  0x00000000 | ADMA Ptr: 0x0000000000000000
mmc1: sdhci: ============================================

It doesn't matter if I use my DT or your DT fragment above.  This used
to work fine with the previous revision of the sdhci-xenon driver.

-- 
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.

[toc] | [prev] | [next] | [standalone]

#1642523 — Re: [PATCH 1/2] arm64: marvell: dts: fill MachiatoBin board description

Hello,

On Tue, 16 May 2017 01:28:32 +0200, Marcin Wojtas wrote:

> +&cps_eth1 {
> +	status = "okay";
> +	phy = <&phy0>;
> +	phy-mode = "sgmii";
> +};

It would be nice to indicate which connector is that, like is done in
the rest of this Device Tree file.

> +&ap_sdhci0 {
> +	status = "okay";
> +	bus-width = <8>;
> +	no-1-8-v;
> +	non-removable;
> +};
> +
> +&cpm_sdhci0 {
> +	status = "okay";
> +	bus-width = <4>;
> +	no-1-8-v;
> +	non-removable;
> +};

Same comment. Also, are they both really non-removable? I have a uSD
card connector on my MacchiatoBin board. It isn't covered by those new
entries ?

Also, fix the wording of MacchiatoBin in your commit title/commit log.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[toc] | [prev] | [next] | [standalone]

#1642538 — Re: [PATCH 1/2] arm64: marvell: dts: fill MachiatoBin board description

On Tue, May 16, 2017 at 02:34:46PM +0200, Thomas Petazzoni wrote:
> > +&ap_sdhci0 {
> > +	status = "okay";
> > +	bus-width = <8>;
> > +	no-1-8-v;
> > +	non-removable;
> > +};
> > +
> > +&cpm_sdhci0 {
> > +	status = "okay";
> > +	bus-width = <4>;
> > +	no-1-8-v;
> > +	non-removable;
> > +};
> 
> Same comment. Also, are they both really non-removable? I have a uSD
> card connector on my MacchiatoBin board. It isn't covered by those new
> entries ?

ap_sdhci is the emmc.  cpm_sdhci is the SD slot.

Had Marcin looked at my tree, or you wait for me to post a mainline
version of my "arm64: dts: marvell: mcbin: add sdhci" patch, you'd
get an entry containing the correct description for the SD slot,
including support for the card detect signal.

However, the SD slot is rather moot at the moment, because sdhci-xenon
appears to be currently broken and non-functional, as I've already
reported.

-- 
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web