Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1642523

Re: [PATCH 1/2] arm64: marvell: dts: fill MachiatoBin board description

Show all headers | View raw

Hello,

On Tue, 16 May 2017 01:28:32 +0200, Marcin Wojtas wrote:

> +&cps_eth1 {
> +	status = "okay";
> +	phy = <&phy0>;
> +	phy-mode = "sgmii";
> +};

It would be nice to indicate which connector is that, like is done in
the rest of this Device Tree file.

> +&ap_sdhci0 {
> +	status = "okay";
> +	bus-width = <8>;
> +	no-1-8-v;
> +	non-removable;
> +};
> +
> +&cpm_sdhci0 {
> +	status = "okay";
> +	bus-width = <4>;
> +	no-1-8-v;
> +	non-removable;
> +};

Same comment. Also, are they both really non-removable? I have a uSD
card connector on my MacchiatoBin board. It isn't covered by those new
entries ?

Also, fix the wording of MacchiatoBin in your commit title/commit log.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] arm64: marvell: dts: fill MachiatoBin board description Marcin Wojtas <mw@semihalf.com> - 2017-05-16 01:30 +0200
  Re: [PATCH 1/2] arm64: marvell: dts: fill MachiatoBin board  description Russell King - ARM Linux <linux@armlinux.org.uk> - 2017-05-16 13:20 +0200
  Re: [PATCH 1/2] arm64: marvell: dts: fill MachiatoBin board  description Thomas Petazzoni <thomas.petazzoni@free-electrons.com> - 2017-05-16 14:40 +0200
    Re: [PATCH 1/2] arm64: marvell: dts: fill MachiatoBin board  description Russell King - ARM Linux <linux@armlinux.org.uk> - 2017-05-16 14:50 +0200

csiph-web