Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1642306 > unrolled thread
| Started by | srishti <srishtishar@gmail.com> |
|---|---|
| First post | 2017-05-16 10:40 +0200 |
| Last post | 2017-05-16 18:00 +0200 |
| Articles | 4 — 4 participants |
Back to article view | Back to linux.kernel
[PATCH] Staging: comedi: comedidev.h: fixed a warning srishti <srishtishar@gmail.com> - 2017-05-16 10:40 +0200
Re: [PATCH] Staging: comedi: comedidev.h: fixed a warning Dan Carpenter <dan.carpenter@oracle.com> - 2017-05-16 10:50 +0200
Re: [PATCH] Staging: comedi: comedidev.h: fixed a warning Greg KH <gregkh@linuxfoundation.org> - 2017-05-16 11:20 +0200
Re: [PATCH] Staging: comedi: comedidev.h: fixed a warning srishti sharma <srishtishar@gmail.com> - 2017-05-16 18:00 +0200
| From | srishti <srishtishar@gmail.com> |
|---|---|
| Date | 2017-05-16 10:40 +0200 |
| Subject | [PATCH] Staging: comedi: comedidev.h: fixed a warning |
| Message-ID | <tHGbn-3ia-7@gated-at.bofh.it> |
Fixed a warning : struct comedi_lrange is generally constant.
Signed-off-by: Srishti Sharma <srishtishar@gmail.com>
---
drivers/staging/comedi/comedidev.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/comedidev.h b/drivers/staging/comedi/comedidev.h
index 1bb9986..82df090 100644
--- a/drivers/staging/comedi/comedidev.h
+++ b/drivers/staging/comedi/comedidev.h
@@ -623,7 +623,7 @@ extern const struct comedi_lrange range_unknown;
* There may also be a flag that indicates the minimum and maximum are merely
* scale factors for an unknown, external reference.
*/
-struct comedi_lrange {
+const struct comedi_lrange {
int length;
struct comedi_krange range[];
};
--
2.7.4
[toc] | [next] | [standalone]
| From | Dan Carpenter <dan.carpenter@oracle.com> |
|---|---|
| Date | 2017-05-16 10:50 +0200 |
| Message-ID | <tHGl3-3lf-3@gated-at.bofh.it> |
| In reply to | #1642306 |
Compile test your patches. regards, dan carpenter
[toc] | [prev] | [next] | [standalone]
| From | Greg KH <gregkh@linuxfoundation.org> |
|---|---|
| Date | 2017-05-16 11:20 +0200 |
| Message-ID | <tHGO6-3K7-13@gated-at.bofh.it> |
| In reply to | #1642306 |
On Tue, May 16, 2017 at 02:00:23PM +0530, srishti wrote: > Fixed a warning : struct comedi_lrange is generally constant. > > Signed-off-by: Srishti Sharma <srishtishar@gmail.com> As Dan pointed out, you _HAVE_ to test-build your changes. Also, your "From:" line didn't match your signed-off-by line, so I couldn't accept this anyway. thanks, greg k-h
[toc] | [prev] | [next] | [standalone]
| From | srishti sharma <srishtishar@gmail.com> |
|---|---|
| Date | 2017-05-16 18:00 +0200 |
| Message-ID | <tHN3c-7uo-17@gated-at.bofh.it> |
| In reply to | #1642331 |
On Tue, May 16, 2017 at 2:45 PM, Greg KH <gregkh@linuxfoundation.org> wrote: > On Tue, May 16, 2017 at 02:00:23PM +0530, srishti wrote: >> Fixed a warning : struct comedi_lrange is generally constant. >> >> Signed-off-by: Srishti Sharma <srishtishar@gmail.com> > > As Dan pointed out, you _HAVE_ to test-build your changes. > > Also, your "From:" line didn't match your signed-off-by line, so I > couldn't accept this anyway. > > thanks, > > greg k-h Thanks for pointing out the error , but this patch is not needed as it was for fixing a warning produced by checkpatch.pl that says struct comedi_lrange is usually constant . But on building the code I get another warning which says that the type qualifier is useless. Regards, Srishti
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web