Re: [PATCH] Staging: comedi: comedidev.h: fixed a warning

From	srishti sharma <srishtishar@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] Staging: comedi: comedidev.h: fixed a warning
Date	2017-05-16 18:00 +0200
Message-ID	<tHN3c-7uo-17@gated-at.bofh.it> (permalink)
References	<tHGbn-3ia-7@gated-at.bofh.it> <tHGO6-3K7-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, May 16, 2017 at 2:45 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
> On Tue, May 16, 2017 at 02:00:23PM +0530, srishti wrote:
>> Fixed a warning : struct comedi_lrange is generally constant.
>>
>> Signed-off-by: Srishti Sharma <srishtishar@gmail.com>
>
> As Dan pointed out, you _HAVE_ to test-build your changes.
>
> Also, your "From:" line didn't match your signed-off-by line, so I
> couldn't accept this anyway.
>
> thanks,
>
> greg k-h

Thanks for pointing out the error , but this patch is not needed as it
was for fixing a warning produced by checkpatch.pl that says struct
comedi_lrange is usually constant . But on building the code I get
another warning which says that the type qualifier is useless.

Regards,
Srishti

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] Staging: comedi: comedidev.h: fixed a warning srishti <srishtishar@gmail.com> - 2017-05-16 10:40 +0200
  Re: [PATCH] Staging: comedi: comedidev.h: fixed a warning Dan Carpenter <dan.carpenter@oracle.com> - 2017-05-16 10:50 +0200
  Re: [PATCH] Staging: comedi: comedidev.h: fixed a warning Greg KH <gregkh@linuxfoundation.org> - 2017-05-16 11:20 +0200
    Re: [PATCH] Staging: comedi: comedidev.h: fixed a warning srishti sharma <srishtishar@gmail.com> - 2017-05-16 18:00 +0200

csiph-web