Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1642277 > unrolled thread

Re: [[media] rc] e662671619: BUG: kernel hang in test stage

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [[media] rc] e662671619: BUG: kernel hang in test stage Sean Young <sean@mess.org> - 2017-05-16 09:50 +0200
    [PATCH] [media] sir_ir: infinite loop in interrupt handler Sean Young <sean@mess.org> - 2017-05-16 10:50 +0200

#1642277 — Re: [[media] rc] e662671619: BUG: kernel hang in test stage

On Mon, May 08, 2017 at 08:13:37PM +0800, kernel test robot wrote:
> Greetings,
> 
> 0day kernel testing robot got the below dmesg and the first bad commit is
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> 
> commit e66267161971155a8b4756b4e17f2f2f82b9f842
> Author:     Sean Young <sean@mess.org>
> AuthorDate: Tue Mar 7 17:07:59 2017 -0300
> Commit:     Mauro Carvalho Chehab <mchehab@s-opensource.com>
> CommitDate: Wed Apr 5 14:50:57 2017 -0300
> 
>     [media] rc: promote lirc_sir out of staging
>     
>     Rename lirc_sir to sir_ir in the process.
>     
>     Signed-off-by: Sean Young <sean@mess.org>
>     Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>

Here the sir_ir gets in an infinite loop in its interrupt handler, since the
hardware is different from what it expects.

I was looking in all the wrong places so it took too long to find this. :/

I'll send a patch as a reply to this email.

Thanks,

Sean

[toc] | [next] | [standalone]

#1642315 — [PATCH] [media] sir_ir: infinite loop in interrupt handler

Since this driver does no detection of hardware, it might be used with
a non-sir port. Escape out if we are spinning.

Signed-off-by: Sean Young <sean@mess.org>
---
 drivers/media/rc/sir_ir.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/media/rc/sir_ir.c b/drivers/media/rc/sir_ir.c
index e12ec50..90a5f8f 100644
--- a/drivers/media/rc/sir_ir.c
+++ b/drivers/media/rc/sir_ir.c
@@ -183,9 +183,15 @@ static irqreturn_t sir_interrupt(int irq, void *dev_id)
 	static unsigned long delt;
 	unsigned long deltintr;
 	unsigned long flags;
+	int counter = 0;
 	int iir, lsr;
 
 	while ((iir = inb(io + UART_IIR) & UART_IIR_ID)) {
+		if (++counter > 256) {
+			dev_err(&sir_ir_dev->dev, "Trapped in interrupt");
+			break;
+		}
+
 		switch (iir & UART_IIR_ID) { /* FIXME toto treba preriedit */
 		case UART_IIR_MSI:
 			(void)inb(io + UART_MSR);
-- 
2.9.4

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web