[PATCH] [media] sir_ir: infinite loop in interrupt handler

From	Sean Young <sean@mess.org>
Newsgroups	linux.kernel
Subject	[PATCH] [media] sir_ir: infinite loop in interrupt handler
Date	2017-05-16 10:50 +0200
Message-ID	<tHGl4-3lf-7@gated-at.bofh.it> (permalink)
References	<tEPNU-3OI-7@gated-at.bofh.it> <tHFp0-2Ho-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Since this driver does no detection of hardware, it might be used with
a non-sir port. Escape out if we are spinning.

Signed-off-by: Sean Young <sean@mess.org>
---
 drivers/media/rc/sir_ir.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/media/rc/sir_ir.c b/drivers/media/rc/sir_ir.c
index e12ec50..90a5f8f 100644
--- a/drivers/media/rc/sir_ir.c
+++ b/drivers/media/rc/sir_ir.c
@@ -183,9 +183,15 @@ static irqreturn_t sir_interrupt(int irq, void *dev_id)
 	static unsigned long delt;
 	unsigned long deltintr;
 	unsigned long flags;
+	int counter = 0;
 	int iir, lsr;
 
 	while ((iir = inb(io + UART_IIR) & UART_IIR_ID)) {
+		if (++counter > 256) {
+			dev_err(&sir_ir_dev->dev, "Trapped in interrupt");
+			break;
+		}
+
 		switch (iir & UART_IIR_ID) { /* FIXME toto treba preriedit */
 		case UART_IIR_MSI:
 			(void)inb(io + UART_MSR);
-- 
2.9.4

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [[media] rc] e662671619: BUG: kernel hang in test stage Sean Young <sean@mess.org> - 2017-05-16 09:50 +0200
  [PATCH] [media] sir_ir: infinite loop in interrupt handler Sean Young <sean@mess.org> - 2017-05-16 10:50 +0200

csiph-web