Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1639944 > unrolled thread
| Started by | Anatolij Gustschin <agust@denx.de> |
|---|---|
| First post | 2017-05-11 20:30 +0200 |
| Last post | 2017-05-22 11:00 +0200 |
| Articles | 5 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH v4] gpiolib: Add stubs for gpiod lookup table interface Anatolij Gustschin <agust@denx.de> - 2017-05-11 20:30 +0200
Re: [PATCH v4] gpiolib: Add stubs for gpiod lookup table interface Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-05-11 21:10 +0200
Re: [PATCH v4] gpiolib: Add stubs for gpiod lookup table interface Linus Walleij <linus.walleij@linaro.org> - 2017-05-12 11:40 +0200
Re: [PATCH v4] gpiolib: Add stubs for gpiod lookup table interface Anatolij Gustschin <agust@denx.de> - 2017-05-12 11:50 +0200
Re: [PATCH v4] gpiolib: Add stubs for gpiod lookup table interface Linus Walleij <linus.walleij@linaro.org> - 2017-05-22 11:00 +0200
| From | Anatolij Gustschin <agust@denx.de> |
|---|---|
| Date | 2017-05-11 20:30 +0200 |
| Subject | [PATCH v4] gpiolib: Add stubs for gpiod lookup table interface |
| Message-ID | <tG10C-1rf-15@gated-at.bofh.it> |
Add stubs for gpiod_add_lookup_table() and gpiod_remove_lookup_table()
for the !GPIOLIB case to prevent build errors.
Signed-off-by: Anatolij Gustschin <agust@denx.de>
---
Changes in v4:
- move stubs to gpio/machine.h
Changes in v3:
- add stubs for !GPIOLIB case. Drop prototypes, these are
already in gpio/machine.h
Changes in v2:
- move gpiod_lookup_table out of #ifdef
include/linux/gpio/machine.h | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/include/linux/gpio/machine.h b/include/linux/gpio/machine.h
index c0d712d..f738d50 100644
--- a/include/linux/gpio/machine.h
+++ b/include/linux/gpio/machine.h
@@ -56,7 +56,14 @@ struct gpiod_lookup_table {
.flags = _flags, \
}
+#ifdef CONFIG_GPIOLIB
void gpiod_add_lookup_table(struct gpiod_lookup_table *table);
void gpiod_remove_lookup_table(struct gpiod_lookup_table *table);
+#else
+static inline
+void gpiod_add_lookup_table(struct gpiod_lookup_table *table) {}
+static inline
+void gpiod_remove_lookup_table(struct gpiod_lookup_table *table) {}
+#endif
#endif /* __LINUX_GPIO_MACHINE_H */
--
2.7.4
[toc] | [next] | [standalone]
| From | Andy Shevchenko <andy.shevchenko@gmail.com> |
|---|---|
| Date | 2017-05-11 21:10 +0200 |
| Message-ID | <tG1Dj-1TS-7@gated-at.bofh.it> |
| In reply to | #1639944 |
On Thu, May 11, 2017 at 9:24 PM, Anatolij Gustschin <agust@denx.de> wrote:
> Add stubs for gpiod_add_lookup_table() and gpiod_remove_lookup_table()
> for the !GPIOLIB case to prevent build errors.
>
Thanks!
FWIW:
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
It will fix this kbuild bot complain: https://lkml.org/lkml/2017/4/2/209
> Signed-off-by: Anatolij Gustschin <agust@denx.de>
> ---
> Changes in v4:
> - move stubs to gpio/machine.h
>
> Changes in v3:
> - add stubs for !GPIOLIB case. Drop prototypes, these are
> already in gpio/machine.h
>
> Changes in v2:
> - move gpiod_lookup_table out of #ifdef
>
> include/linux/gpio/machine.h | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/include/linux/gpio/machine.h b/include/linux/gpio/machine.h
> index c0d712d..f738d50 100644
> --- a/include/linux/gpio/machine.h
> +++ b/include/linux/gpio/machine.h
> @@ -56,7 +56,14 @@ struct gpiod_lookup_table {
> .flags = _flags, \
> }
>
> +#ifdef CONFIG_GPIOLIB
> void gpiod_add_lookup_table(struct gpiod_lookup_table *table);
> void gpiod_remove_lookup_table(struct gpiod_lookup_table *table);
> +#else
> +static inline
> +void gpiod_add_lookup_table(struct gpiod_lookup_table *table) {}
> +static inline
> +void gpiod_remove_lookup_table(struct gpiod_lookup_table *table) {}
> +#endif
>
> #endif /* __LINUX_GPIO_MACHINE_H */
> --
> 2.7.4
>
--
With Best Regards,
Andy Shevchenko
[toc] | [prev] | [next] | [standalone]
| From | Linus Walleij <linus.walleij@linaro.org> |
|---|---|
| Date | 2017-05-12 11:40 +0200 |
| Message-ID | <tGfdg-2rg-13@gated-at.bofh.it> |
| In reply to | #1639944 |
On Thu, May 11, 2017 at 8:24 PM, Anatolij Gustschin <agust@denx.de> wrote: > Add stubs for gpiod_add_lookup_table() and gpiod_remove_lookup_table() > for the !GPIOLIB case to prevent build errors. > > Signed-off-by: Anatolij Gustschin <agust@denx.de> Patch applied for fixes with Andy's Review tag. Yours, Linus Walleij
[toc] | [prev] | [next] | [standalone]
| From | Anatolij Gustschin <agust@denx.de> |
|---|---|
| Date | 2017-05-12 11:50 +0200 |
| Message-ID | <tGfmV-2vB-7@gated-at.bofh.it> |
| In reply to | #1640356 |
On Fri, 12 May 2017 11:27:42 +0200 Linus Walleij linus.walleij@linaro.org wrote: ... >Patch applied for fixes with Andy's Review tag. Thanks! What about this one https://lkml.org/lkml/2017/4/20/907 ? Any issues with it? Or can it be queued for v4.13? Thanks, Anatolij
[toc] | [prev] | [next] | [standalone]
| From | Linus Walleij <linus.walleij@linaro.org> |
|---|---|
| Date | 2017-05-22 11:00 +0200 |
| Message-ID | <tJRm2-3g5-9@gated-at.bofh.it> |
| In reply to | #1640364 |
On Fri, May 12, 2017 at 11:38 AM, Anatolij Gustschin <agust@denx.de> wrote: > On Fri, 12 May 2017 11:27:42 +0200 > Linus Walleij linus.walleij@linaro.org wrote: > ... >>Patch applied for fixes with Andy's Review tag. > > Thanks! What about this one https://lkml.org/lkml/2017/4/20/907 ? > Any issues with it? Or can it be queued for v4.13? It was probably not sent to me (just to the mailing list?) or some other hickup. I will try to find it min my mailbox. Yours, Linus Walleij
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web