Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1639970

Re: [PATCH v4] gpiolib: Add stubs for gpiod lookup table interface

Show all headers | View raw

On Thu, May 11, 2017 at 9:24 PM, Anatolij Gustschin <agust@denx.de> wrote:
> Add stubs for gpiod_add_lookup_table() and gpiod_remove_lookup_table()
> for the !GPIOLIB case to prevent build errors.
>

Thanks!

FWIW:
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>

It will fix this kbuild bot complain: https://lkml.org/lkml/2017/4/2/209

> Signed-off-by: Anatolij Gustschin <agust@denx.de>
> ---
> Changes in v4:
>  - move stubs to gpio/machine.h
>
> Changes in v3:
>  - add stubs for !GPIOLIB case. Drop prototypes, these are
>    already in gpio/machine.h
>
> Changes in v2:
>  - move gpiod_lookup_table out of #ifdef
>
>  include/linux/gpio/machine.h | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/include/linux/gpio/machine.h b/include/linux/gpio/machine.h
> index c0d712d..f738d50 100644
> --- a/include/linux/gpio/machine.h
> +++ b/include/linux/gpio/machine.h
> @@ -56,7 +56,14 @@ struct gpiod_lookup_table {
>         .flags = _flags,                                                  \
>  }
>
> +#ifdef CONFIG_GPIOLIB
>  void gpiod_add_lookup_table(struct gpiod_lookup_table *table);
>  void gpiod_remove_lookup_table(struct gpiod_lookup_table *table);
> +#else
> +static inline
> +void gpiod_add_lookup_table(struct gpiod_lookup_table *table) {}
> +static inline
> +void gpiod_remove_lookup_table(struct gpiod_lookup_table *table) {}
> +#endif
>
>  #endif /* __LINUX_GPIO_MACHINE_H */
> --
> 2.7.4
>



-- 
With Best Regards,
Andy Shevchenko

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v4] gpiolib: Add stubs for gpiod lookup table interface Anatolij Gustschin <agust@denx.de> - 2017-05-11 20:30 +0200
  Re: [PATCH v4] gpiolib: Add stubs for gpiod lookup table interface Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-05-11 21:10 +0200
  Re: [PATCH v4] gpiolib: Add stubs for gpiod lookup table interface Linus Walleij <linus.walleij@linaro.org> - 2017-05-12 11:40 +0200
    Re: [PATCH v4] gpiolib: Add stubs for gpiod lookup table interface Anatolij Gustschin <agust@denx.de> - 2017-05-12 11:50 +0200
      Re: [PATCH v4] gpiolib: Add stubs for gpiod lookup table interface Linus Walleij <linus.walleij@linaro.org> - 2017-05-22 11:00 +0200

csiph-web