Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1639599 > unrolled thread
| Started by | Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
|---|---|
| First post | 2017-05-11 16:40 +0200 |
| Last post | 2017-05-12 11:50 +0200 |
| Articles | 4 — 3 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH 4.4 16/60] x86/ioapic: Restore IO-APIC irq_chip retrigger callback Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-05-11 16:40 +0200
Re: [PATCH 4.4 16/60] x86/ioapic: Restore IO-APIC irq_chip retrigger callback Ben Hutchings <ben.hutchings@codethink.co.uk> - 2017-05-11 19:10 +0200
Re: [PATCH 4.4 16/60] x86/ioapic: Restore IO-APIC irq_chip retrigger callback Thomas Gleixner <tglx@linutronix.de> - 2017-05-11 23:20 +0200
Re: [PATCH 4.4 16/60] x86/ioapic: Restore IO-APIC irq_chip retrigger callback Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-05-12 11:50 +0200
| From | Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
|---|---|
| Date | 2017-05-11 16:40 +0200 |
| Subject | [PATCH 4.4 16/60] x86/ioapic: Restore IO-APIC irq_chip retrigger callback |
| Message-ID | <tFXq2-7wN-19@gated-at.bofh.it> |
4.4-stable review patch. If anyone has any objections, please let me know.
------------------
From: Ruslan Ruslichenko <rruslich@cisco.com>
commit a9b4f08770b415f30f2fb0f8329a370c8f554aa3 upstream.
commit d32932d02e18 removed the irq_retrigger callback from the IO-APIC
chip and did not add it to the new IO-APIC-IR irq chip.
There is no harm because the interrupts are resent in software when the
retrigger callback is NULL, but it's less efficient. So restore them.
[ tglx: Massaged changelog ]
Fixes: d32932d02e18 ("x86/irq: Convert IOAPIC to use hierarchical irqdomain interfaces")
Signed-off-by: Ruslan Ruslichenko <rruslich@cisco.com>
Cc: xe-linux-external@cisco.com
Link: http://lkml.kernel.org/r/1484662432-13580-1-git-send-email-rruslich@cisco.com
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
arch/x86/kernel/apic/io_apic.c | 2 ++
1 file changed, 2 insertions(+)
--- a/arch/x86/kernel/apic/io_apic.c
+++ b/arch/x86/kernel/apic/io_apic.c
@@ -1875,6 +1875,7 @@ static struct irq_chip ioapic_chip __rea
.irq_ack = irq_chip_ack_parent,
.irq_eoi = ioapic_ack_level,
.irq_set_affinity = ioapic_set_affinity,
+ .irq_retrigger = irq_chip_retrigger_hierarchy,
.flags = IRQCHIP_SKIP_SET_WAKE,
};
@@ -1886,6 +1887,7 @@ static struct irq_chip ioapic_ir_chip __
.irq_ack = irq_chip_ack_parent,
.irq_eoi = ioapic_ir_ack_level,
.irq_set_affinity = ioapic_set_affinity,
+ .irq_retrigger = irq_chip_retrigger_hierarchy,
.flags = IRQCHIP_SKIP_SET_WAKE,
};
[toc] | [next] | [standalone]
| From | Ben Hutchings <ben.hutchings@codethink.co.uk> |
|---|---|
| Date | 2017-05-11 19:10 +0200 |
| Subject | Re: [PATCH 4.4 16/60] x86/ioapic: Restore IO-APIC irq_chip retrigger callback |
| Message-ID | <tFZLc-KD-13@gated-at.bofh.it> |
| In reply to | #1639599 |
On Thu, 2017-05-11 at 16:12 +0200, Greg Kroah-Hartman wrote:
> 4.4-stable review patch. If anyone has any objections, please let me know.
>
> ------------------
>
> From: Ruslan Ruslichenko <rruslich@cisco.com>
>
> commit a9b4f08770b415f30f2fb0f8329a370c8f554aa3 upstream.
>
> commit d32932d02e18 removed the irq_retrigger callback from the IO-APIC
> chip and did not add it to the new IO-APIC-IR irq chip.
>
> There is no harm because the interrupts are resent in software when the
> retrigger callback is NULL, but it's less efficient. So restore them.
Sounds like it's not important enough for stable, then?
Ben.
> [ tglx: Massaged changelog ]
>
> Fixes: d32932d02e18 ("x86/irq: Convert IOAPIC to use hierarchical irqdomain interfaces")
> Signed-off-by: Ruslan Ruslichenko <rruslich@cisco.com>
> Cc: xe-linux-external@cisco.com
> Link: http://lkml.kernel.org/r/1484662432-13580-1-git-send-email-rruslich@cisco.com
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>
> ---
> arch/x86/kernel/apic/io_apic.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> --- a/arch/x86/kernel/apic/io_apic.c
> +++ b/arch/x86/kernel/apic/io_apic.c
> @@ -1875,6 +1875,7 @@ static struct irq_chip ioapic_chip __rea
> .irq_ack = irq_chip_ack_parent,
> .irq_eoi = ioapic_ack_level,
> .irq_set_affinity = ioapic_set_affinity,
> + .irq_retrigger = irq_chip_retrigger_hierarchy,
> .flags = IRQCHIP_SKIP_SET_WAKE,
> };
>
> @@ -1886,6 +1887,7 @@ static struct irq_chip ioapic_ir_chip __
> .irq_ack = irq_chip_ack_parent,
> .irq_eoi = ioapic_ir_ack_level,
> .irq_set_affinity = ioapic_set_affinity,
> + .irq_retrigger = irq_chip_retrigger_hierarchy,
> .flags = IRQCHIP_SKIP_SET_WAKE,
> };
>
>
>
>
--
Ben Hutchings
Software Developer, Codethink Ltd.
[toc] | [prev] | [next] | [standalone]
| From | Thomas Gleixner <tglx@linutronix.de> |
|---|---|
| Date | 2017-05-11 23:20 +0200 |
| Subject | Re: [PATCH 4.4 16/60] x86/ioapic: Restore IO-APIC irq_chip retrigger callback |
| Message-ID | <tG3F7-3bi-9@gated-at.bofh.it> |
| In reply to | #1639905 |
On Thu, 11 May 2017, Ben Hutchings wrote:
> On Thu, 2017-05-11 at 16:12 +0200, Greg Kroah-Hartman wrote:
> > 4.4-stable review patch. If anyone has any objections, please let me know.
> >
> > ------------------
> >
> > From: Ruslan Ruslichenko <rruslich@cisco.com>
> >
> > commit a9b4f08770b415f30f2fb0f8329a370c8f554aa3 upstream.
> >
> > commit d32932d02e18 removed the irq_retrigger callback from the IO-APIC
> > chip and did not add it to the new IO-APIC-IR irq chip.
> >
> > There is no harm because the interrupts are resent in software when the
> > retrigger callback is NULL, but it's less efficient. So restore them.
>
> Sounds like it's not important enough for stable, then?
Actually that changelog is wrong, but this commit got reverted because it
triggered some crap code.
After we fixed that it was brought back with:
020eb3daaba2857b32c4cf4c82f503d6a00a67de
The related fixes are:
47512cfd0d7a8bd6ab71d01cd89fca19eb2093eb
6cf18e6927c0b224f972e3042fb85770d63cb9f8
which are both tagged for stable as well.
Thanks,
tglx
[toc] | [prev] | [next] | [standalone]
| From | Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
|---|---|
| Date | 2017-05-12 11:50 +0200 |
| Subject | Re: [PATCH 4.4 16/60] x86/ioapic: Restore IO-APIC irq_chip retrigger callback |
| Message-ID | <tGfmV-2vB-9@gated-at.bofh.it> |
| In reply to | #1640051 |
On Thu, May 11, 2017 at 11:17:59PM +0200, Thomas Gleixner wrote: > On Thu, 11 May 2017, Ben Hutchings wrote: > > > On Thu, 2017-05-11 at 16:12 +0200, Greg Kroah-Hartman wrote: > > > 4.4-stable review patch. If anyone has any objections, please let me know. > > > > > > ------------------ > > > > > > From: Ruslan Ruslichenko <rruslich@cisco.com> > > > > > > commit a9b4f08770b415f30f2fb0f8329a370c8f554aa3 upstream. > > > > > > commit d32932d02e18 removed the irq_retrigger callback from the IO-APIC > > > chip and did not add it to the new IO-APIC-IR irq chip. > > > > > > There is no harm because the interrupts are resent in software when the > > > retrigger callback is NULL, but it's less efficient. So restore them. > > > > Sounds like it's not important enough for stable, then? > > Actually that changelog is wrong, but this commit got reverted because it > triggered some crap code. > > After we fixed that it was brought back with: > > 020eb3daaba2857b32c4cf4c82f503d6a00a67de > > The related fixes are: > > 47512cfd0d7a8bd6ab71d01cd89fca19eb2093eb > 6cf18e6927c0b224f972e3042fb85770d63cb9f8 > > which are both tagged for stable as well. Those both are in stable already, so this should be safe to add, so I'll leave it as-is. thanks, greg k-h
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web