Re: [PATCH 4.4 16/60] x86/ioapic: Restore IO-APIC irq_chip retrigger callback

From	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 4.4 16/60] x86/ioapic: Restore IO-APIC irq_chip retrigger callback
Date	2017-05-12 11:50 +0200
Message-ID	<tGfmV-2vB-9@gated-at.bofh.it> (permalink)
References	<tFXgl-7ta-3@gated-at.bofh.it> <tFXq2-7wN-19@gated-at.bofh.it> <tFZLc-KD-13@gated-at.bofh.it> <tG3F7-3bi-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, May 11, 2017 at 11:17:59PM +0200, Thomas Gleixner wrote:
> On Thu, 11 May 2017, Ben Hutchings wrote:
> 
> > On Thu, 2017-05-11 at 16:12 +0200, Greg Kroah-Hartman wrote:
> > > 4.4-stable review patch.  If anyone has any objections, please let me know.
> > > 
> > > ------------------
> > > 
> > > From: Ruslan Ruslichenko <rruslich@cisco.com>
> > > 
> > > commit a9b4f08770b415f30f2fb0f8329a370c8f554aa3 upstream.
> > > 
> > > commit d32932d02e18 removed the irq_retrigger callback from the IO-APIC
> > > chip and did not add it to the new IO-APIC-IR irq chip.
> > > 
> > > There is no harm because the interrupts are resent in software when the
> > > retrigger callback is NULL, but it's less efficient. So restore them.
> > 
> > Sounds like it's not important enough for stable, then?
> 
> Actually that changelog is wrong, but this commit got reverted because it
> triggered some crap code.
> 
> After we fixed that it was brought back with:
> 
>       020eb3daaba2857b32c4cf4c82f503d6a00a67de
> 
> The related fixes are:
> 
>     47512cfd0d7a8bd6ab71d01cd89fca19eb2093eb
>     6cf18e6927c0b224f972e3042fb85770d63cb9f8
> 
> which are both tagged for stable as well.

Those both are in stable already, so this should be safe to add, so I'll
leave it as-is.

thanks,

greg k-h

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 4.4 16/60] x86/ioapic: Restore IO-APIC irq_chip retrigger callback Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-05-11 16:40 +0200
  Re: [PATCH 4.4 16/60] x86/ioapic: Restore IO-APIC irq_chip  retrigger callback Ben Hutchings <ben.hutchings@codethink.co.uk> - 2017-05-11 19:10 +0200
    Re: [PATCH 4.4 16/60] x86/ioapic: Restore IO-APIC irq_chip retrigger  callback Thomas Gleixner <tglx@linutronix.de> - 2017-05-11 23:20 +0200
      Re: [PATCH 4.4 16/60] x86/ioapic: Restore IO-APIC irq_chip retrigger  callback Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-05-12 11:50 +0200

csiph-web