Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1638305 > unrolled thread
| Started by | Colin King <colin.king@canonical.com> |
|---|---|
| First post | 2017-05-09 19:20 +0200 |
| Last post | 2017-05-10 17:20 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] btrfs: fix incorrect error return ret being passed to mapping_set_error Colin King <colin.king@canonical.com> - 2017-05-09 19:20 +0200
Re: [PATCH] btrfs: fix incorrect error return ret being passed to mapping_set_error Liu Bo <bo.li.liu@oracle.com> - 2017-05-09 21:10 +0200
Re: [PATCH] btrfs: fix incorrect error return ret being passed to mapping_set_error David Sterba <dsterba@suse.cz> - 2017-05-10 17:20 +0200
| From | Colin King <colin.king@canonical.com> |
|---|---|
| Date | 2017-05-09 19:20 +0200 |
| Subject | [PATCH] btrfs: fix incorrect error return ret being passed to mapping_set_error |
| Message-ID | <tFgXL-4Lx-1@gated-at.bofh.it> |
From: Colin Ian King <colin.king@canonical.com>
The setting of return code ret should be based on the error code
passed into function end_extent_writepage and not on ret. Thanks
to Liu Bo for spotting this mistake in the original fix I submitted.
Detected by CoverityScan, CID#1414312 ("Logically dead code")
Fixes: 5dca6eea91653e ("Btrfs: mark mapping with error flag to report errors to userspace")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
fs/btrfs/extent_io.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/btrfs/extent_io.c b/fs/btrfs/extent_io.c
index d8da3edf2ac3..7c6a032df585 100644
--- a/fs/btrfs/extent_io.c
+++ b/fs/btrfs/extent_io.c
@@ -2458,7 +2458,7 @@ void end_extent_writepage(struct page *page, int err, u64 start, u64 end)
if (!uptodate) {
ClearPageUptodate(page);
SetPageError(page);
- ret = ret < 0 ? ret : -EIO;
+ ret = err < 0 ? err : -EIO;
mapping_set_error(page->mapping, ret);
}
}
--
2.11.0
[toc] | [next] | [standalone]
| From | Liu Bo <bo.li.liu@oracle.com> |
|---|---|
| Date | 2017-05-09 21:10 +0200 |
| Subject | Re: [PATCH] btrfs: fix incorrect error return ret being passed to mapping_set_error |
| Message-ID | <tFiGd-5YT-1@gated-at.bofh.it> |
| In reply to | #1638305 |
On Tue, May 09, 2017 at 06:14:01PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The setting of return code ret should be based on the error code
> passed into function end_extent_writepage and not on ret. Thanks
> to Liu Bo for spotting this mistake in the original fix I submitted.
>
> Detected by CoverityScan, CID#1414312 ("Logically dead code")
Looks good.
Reviewed-by: Liu Bo <bo.li.liu@oracle.com>
Thanks,
-liubo
>
> Fixes: 5dca6eea91653e ("Btrfs: mark mapping with error flag to report errors to userspace")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> fs/btrfs/extent_io.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/btrfs/extent_io.c b/fs/btrfs/extent_io.c
> index d8da3edf2ac3..7c6a032df585 100644
> --- a/fs/btrfs/extent_io.c
> +++ b/fs/btrfs/extent_io.c
> @@ -2458,7 +2458,7 @@ void end_extent_writepage(struct page *page, int err, u64 start, u64 end)
> if (!uptodate) {
> ClearPageUptodate(page);
> SetPageError(page);
> - ret = ret < 0 ? ret : -EIO;
> + ret = err < 0 ? err : -EIO;
> mapping_set_error(page->mapping, ret);
> }
> }
> --
> 2.11.0
>
[toc] | [prev] | [next] | [standalone]
| From | David Sterba <dsterba@suse.cz> |
|---|---|
| Date | 2017-05-10 17:20 +0200 |
| Subject | Re: [PATCH] btrfs: fix incorrect error return ret being passed to mapping_set_error |
| Message-ID | <tFBzc-2lT-19@gated-at.bofh.it> |
| In reply to | #1638351 |
On Tue, May 09, 2017 at 11:58:55AM -0700, Liu Bo wrote:
> On Tue, May 09, 2017 at 06:14:01PM +0100, Colin King wrote:
> > From: Colin Ian King <colin.king@canonical.com>
> >
> > The setting of return code ret should be based on the error code
> > passed into function end_extent_writepage and not on ret. Thanks
> > to Liu Bo for spotting this mistake in the original fix I submitted.
> >
> > Detected by CoverityScan, CID#1414312 ("Logically dead code")
>
> Looks good.
>
> Reviewed-by: Liu Bo <bo.li.liu@oracle.com>
Thanks, patch replaced.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web