Re: [PATCH] btrfs: fix incorrect error return ret being passed to mapping_set_error

From	David Sterba <dsterba@suse.cz>
Newsgroups	linux.kernel
Subject	Re: [PATCH] btrfs: fix incorrect error return ret being passed to mapping_set_error
Date	2017-05-10 17:20 +0200
Message-ID	<tFBzc-2lT-19@gated-at.bofh.it> (permalink)
References	<tFgXL-4Lx-1@gated-at.bofh.it> <tFiGd-5YT-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, May 09, 2017 at 11:58:55AM -0700, Liu Bo wrote:
> On Tue, May 09, 2017 at 06:14:01PM +0100, Colin King wrote:
> > From: Colin Ian King <colin.king@canonical.com>
> > 
> > The setting of return code ret should be based on the error code
> > passed into function end_extent_writepage and not on ret. Thanks
> > to Liu Bo for spotting this mistake in the original fix I submitted.
> > 
> > Detected by CoverityScan, CID#1414312 ("Logically dead code")
> 
> Looks good.
> 
> Reviewed-by: Liu Bo <bo.li.liu@oracle.com>

Thanks, patch replaced.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] btrfs: fix incorrect error return ret being passed to mapping_set_error Colin King <colin.king@canonical.com> - 2017-05-09 19:20 +0200
  Re: [PATCH] btrfs: fix incorrect error return ret being passed to  mapping_set_error Liu Bo <bo.li.liu@oracle.com> - 2017-05-09 21:10 +0200
    Re: [PATCH] btrfs: fix incorrect error return ret being passed to  mapping_set_error David Sterba <dsterba@suse.cz> - 2017-05-10 17:20 +0200

csiph-web