Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1634054 > unrolled thread
| Started by | Justin Vreeland <justin@jvreeland.com> |
|---|---|
| First post | 2017-05-02 03:00 +0200 |
| Last post | 2017-05-04 14:00 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH v2 3/7] staging: rtl8723bs: Macros with complex values should be enclosed in parentheses Justin Vreeland <justin@jvreeland.com> - 2017-05-02 03:00 +0200
Re: [PATCH v2 3/7] staging: rtl8723bs: Macros with complex values should be enclosed in parentheses Bastien Nocera <hadess@hadess.net> - 2017-05-04 14:00 +0200
| From | Justin Vreeland <justin@jvreeland.com> |
|---|---|
| Date | 2017-05-02 03:00 +0200 |
| Subject | [PATCH v2 3/7] staging: rtl8723bs: Macros with complex values should be enclosed in parentheses |
| Message-ID | <tCuky-7Ii-1@gated-at.bofh.it> |
Enclosing macros with complex values ensures expression is evaluated as
expected.
Signed-off-by: Justin Vreeland <justin@jvreeland.com>
---
v2:
- Added spaces around plus signs
- Fixed line over 80 columns
- Added commit message
drivers/staging/rtl8723bs/hal/odm.h | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8723bs/hal/odm.h b/drivers/staging/rtl8723bs/hal/odm.h
index 0b3541a91548..87a76bafecb3 100644
--- a/drivers/staging/rtl8723bs/hal/odm.h
+++ b/drivers/staging/rtl8723bs/hal/odm.h
@@ -209,7 +209,10 @@ typedef struct _ODM_RATE_ADAPTIVE {
#define AVG_THERMAL_NUM 8
#define IQK_Matrix_REG_NUM 8
-#define IQK_Matrix_Settings_NUM 14+24+21 /* Channels_2_4G_NUM + Channels_5G_20M_NUM + Channels_5G */
+#define IQK_Matrix_Settings_NUM (14 + 24 + 21) /* Channels_2_4G_NUM
+ * + Channels_5G_20M_NUM
+ * + Channels_5G
+ */
#define DM_Type_ByFW 0
#define DM_Type_ByDriver 1
--
2.12.2
[toc] | [next] | [standalone]
| From | Bastien Nocera <hadess@hadess.net> |
|---|---|
| Date | 2017-05-04 14:00 +0200 |
| Subject | Re: [PATCH v2 3/7] staging: rtl8723bs: Macros with complex values should be enclosed in parentheses |
| Message-ID | <tDnAm-2VI-25@gated-at.bofh.it> |
| In reply to | #1634054 |
On Mon, 2017-05-01 at 18:52 -0600, Justin Vreeland wrote:
> Enclosing macros with complex values ensures expression is evaluated
> as
> expected.
>
> Signed-off-by: Justin Vreeland <justin@jvreeland.com>
> ---
> v2:
> - Added spaces around plus signs
> - Fixed line over 80 columns
> - Added commit message
>
> drivers/staging/rtl8723bs/hal/odm.h | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8723bs/hal/odm.h
> b/drivers/staging/rtl8723bs/hal/odm.h
> index 0b3541a91548..87a76bafecb3 100644
> --- a/drivers/staging/rtl8723bs/hal/odm.h
> +++ b/drivers/staging/rtl8723bs/hal/odm.h
> @@ -209,7 +209,10 @@ typedef struct _ODM_RATE_ADAPTIVE {
>
> #define AVG_THERMAL_NUM 8
> #define IQK_Matrix_REG_NUM 8
> -#define IQK_Matrix_Settings_NUM 14+24+21
> /* Channels_2_4G_NUM + Channels_5G_20M_NUM + Channels_5G */
> +#define IQK_Matrix_Settings_NUM (14 + 24 + 21)
> /* Channels_2_4G_NUM
> + * +
> Channels_5G_20M_NUM
> + * + Channels_5G
> + */
This does line up when applied, right? If so:
Reviewed-by: Bastien Nocera <hadess@hadess.net>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web