Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1635668
| From | Bastien Nocera <hadess@hadess.net> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2 3/7] staging: rtl8723bs: Macros with complex values should be enclosed in parentheses |
| Date | 2017-05-04 14:00 +0200 |
| Message-ID | <tDnAm-2VI-25@gated-at.bofh.it> (permalink) |
| References | <tCuky-7Ii-3@gated-at.bofh.it> <tCuky-7Ii-1@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Mon, 2017-05-01 at 18:52 -0600, Justin Vreeland wrote:
> Enclosing macros with complex values ensures expression is evaluated
> as
> expected.
>
> Signed-off-by: Justin Vreeland <justin@jvreeland.com>
> ---
> v2:
> - Added spaces around plus signs
> - Fixed line over 80 columns
> - Added commit message
>
> drivers/staging/rtl8723bs/hal/odm.h | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8723bs/hal/odm.h
> b/drivers/staging/rtl8723bs/hal/odm.h
> index 0b3541a91548..87a76bafecb3 100644
> --- a/drivers/staging/rtl8723bs/hal/odm.h
> +++ b/drivers/staging/rtl8723bs/hal/odm.h
> @@ -209,7 +209,10 @@ typedef struct _ODM_RATE_ADAPTIVE {
>
> #define AVG_THERMAL_NUM 8
> #define IQK_Matrix_REG_NUM 8
> -#define IQK_Matrix_Settings_NUM 14+24+21
> /* Channels_2_4G_NUM + Channels_5G_20M_NUM + Channels_5G */
> +#define IQK_Matrix_Settings_NUM (14 + 24 + 21)
> /* Channels_2_4G_NUM
> + * +
> Channels_5G_20M_NUM
> + * + Channels_5G
> + */
This does line up when applied, right? If so:
Reviewed-by: Bastien Nocera <hadess@hadess.net>
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
[PATCH v2 3/7] staging: rtl8723bs: Macros with complex values should be enclosed in parentheses Justin Vreeland <justin@jvreeland.com> - 2017-05-02 03:00 +0200 Re: [PATCH v2 3/7] staging: rtl8723bs: Macros with complex values should be enclosed in parentheses Bastien Nocera <hadess@hadess.net> - 2017-05-04 14:00 +0200
csiph-web