Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1635191 > unrolled thread
| Started by | Bart Van Assche <Bart.VanAssche@sandisk.com> |
|---|---|
| First post | 2017-05-03 20:30 +0200 |
| Last post | 2017-05-03 20:30 +0200 |
| Articles | 1 — 1 participant |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH] sd: Ignore sync cache failures when not supported Bart Van Assche <Bart.VanAssche@sandisk.com> - 2017-05-03 20:30 +0200
| From | Bart Van Assche <Bart.VanAssche@sandisk.com> |
|---|---|
| Date | 2017-05-03 20:30 +0200 |
| Subject | Re: [PATCH] sd: Ignore sync cache failures when not supported |
| Message-ID | <tD7ce-Ai-5@gated-at.bofh.it> |
On Thu, 2017-03-16 at 17:48 +0100, Thierry Escande wrote:
> -static int sd_sync_cache(struct scsi_disk *sdkp)
> +static int sd_sync_cache(struct scsi_disk *sdkp, int *sense_key)
> {
> int retries, res;
> struct scsi_device *sdp = sdkp->device;
Hello Thierry,
Both in the SCSI spec and in struct scsi_sense_hdr sense keys are declared
as eight bit values. So I would appreciate if the sense_key data type would
be changed from "int" into "u8". Otherwise this patch looks fine to me.
Thanks,
Bart.
Back to top | Article view | linux.kernel
csiph-web