Re: [PATCH] sd: Ignore sync cache failures when not supported

From	Bart Van Assche <Bart.VanAssche@sandisk.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] sd: Ignore sync cache failures when not supported
Date	2017-05-03 20:30 +0200
Message-ID	<tD7ce-Ai-5@gated-at.bofh.it> (permalink)
References	<tlGL8-14c-27@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, 2017-03-16 at 17:48 +0100, Thierry Escande wrote:
> -static int sd_sync_cache(struct scsi_disk *sdkp)
> +static int sd_sync_cache(struct scsi_disk *sdkp, int *sense_key)
>  {
>  	int retries, res;
>  	struct scsi_device *sdp = sdkp->device;

Hello Thierry,

Both in the SCSI spec and in struct scsi_sense_hdr sense keys are declared
as eight bit values. So I would appreciate if the sense_key data type would
be changed from "int" into "u8". Otherwise this patch looks fine to me.

Thanks,

Bart.

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] sd: Ignore sync cache failures when not supported Bart Van Assche <Bart.VanAssche@sandisk.com> - 2017-05-03 20:30 +0200

csiph-web