Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1634860 > unrolled thread
| Started by | Colin King <colin.king@canonical.com> |
|---|---|
| First post | 2017-05-03 12:50 +0200 |
| Last post | 2017-05-04 17:30 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] power: supply: bq27xxx: make bq27xxx_battery_settings static Colin King <colin.king@canonical.com> - 2017-05-03 12:50 +0200
Re: [PATCH] power: supply: bq27xxx: make bq27xxx_battery_settings static Pali Rohár <pali.rohar@gmail.com> - 2017-05-04 10:20 +0200
Re: [PATCH] power: supply: bq27xxx: make bq27xxx_battery_settings static Sebastian Reichel <sebastian.reichel@collabora.co.uk> - 2017-05-04 17:30 +0200
| From | Colin King <colin.king@canonical.com> |
|---|---|
| Date | 2017-05-03 12:50 +0200 |
| Subject | [PATCH] power: supply: bq27xxx: make bq27xxx_battery_settings static |
| Message-ID | <tD014-46P-13@gated-at.bofh.it> |
From: Colin Ian King <colin.king@canonical.com>
The function bq27xxx_battery_settings can be made static as it
does not need to be in global scope.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/power/supply/bq27xxx_battery.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/power/supply/bq27xxx_battery.c b/drivers/power/supply/bq27xxx_battery.c
index 7152370b9d61..06f15da32464 100644
--- a/drivers/power/supply/bq27xxx_battery.c
+++ b/drivers/power/supply/bq27xxx_battery.c
@@ -1251,7 +1251,7 @@ static void bq27xxx_battery_set_config(struct bq27xxx_device_info *di,
/* assume bq27xxx_battery_update() is called hereafter */
}
-void bq27xxx_battery_settings(struct bq27xxx_device_info *di)
+static void bq27xxx_battery_settings(struct bq27xxx_device_info *di)
{
struct power_supply_battery_info info = {};
unsigned int min, max;
--
2.11.0
[toc] | [next] | [standalone]
| From | Pali Rohár <pali.rohar@gmail.com> |
|---|---|
| Date | 2017-05-04 10:20 +0200 |
| Subject | Re: [PATCH] power: supply: bq27xxx: make bq27xxx_battery_settings static |
| Message-ID | <tDk9s-S5-17@gated-at.bofh.it> |
| In reply to | #1634860 |
On Wednesday 03 May 2017 11:45:54 Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The function bq27xxx_battery_settings can be made static as it
> does not need to be in global scope.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/power/supply/bq27xxx_battery.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/power/supply/bq27xxx_battery.c b/drivers/power/supply/bq27xxx_battery.c
> index 7152370b9d61..06f15da32464 100644
> --- a/drivers/power/supply/bq27xxx_battery.c
> +++ b/drivers/power/supply/bq27xxx_battery.c
> @@ -1251,7 +1251,7 @@ static void bq27xxx_battery_set_config(struct bq27xxx_device_info *di,
> /* assume bq27xxx_battery_update() is called hereafter */
> }
>
> -void bq27xxx_battery_settings(struct bq27xxx_device_info *di)
> +static void bq27xxx_battery_settings(struct bq27xxx_device_info *di)
> {
> struct power_supply_battery_info info = {};
> unsigned int min, max;
Reviewed-by: Pali Rohár <pali.rohar@gmail.com>
--
Pali Rohár
pali.rohar@gmail.com
[toc] | [prev] | [next] | [standalone]
| From | Sebastian Reichel <sebastian.reichel@collabora.co.uk> |
|---|---|
| Date | 2017-05-04 17:30 +0200 |
| Subject | Re: [PATCH] power: supply: bq27xxx: make bq27xxx_battery_settings static |
| Message-ID | <tDqRA-5hr-3@gated-at.bofh.it> |
| In reply to | #1634860 |
[Multipart message — attachments visible in raw view] — view raw
Hi, On Wed, May 03, 2017 at 11:45:54AM +0100, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > The function bq27xxx_battery_settings can be made static as it > does not need to be in global scope. > > Signed-off-by: Colin Ian King <colin.king@canonical.com> Thanks, I dropped Liam's patches instead. -- Sebastian
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web