Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1635473

Re: [PATCH] power: supply: bq27xxx: make bq27xxx_battery_settings static

Show all headers | View raw

On Wednesday 03 May 2017 11:45:54 Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> The function bq27xxx_battery_settings can be made static as it
> does not need to be in global scope.
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  drivers/power/supply/bq27xxx_battery.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/power/supply/bq27xxx_battery.c b/drivers/power/supply/bq27xxx_battery.c
> index 7152370b9d61..06f15da32464 100644
> --- a/drivers/power/supply/bq27xxx_battery.c
> +++ b/drivers/power/supply/bq27xxx_battery.c
> @@ -1251,7 +1251,7 @@ static void bq27xxx_battery_set_config(struct bq27xxx_device_info *di,
>  	/* assume bq27xxx_battery_update() is called hereafter */
>  }
>  
> -void bq27xxx_battery_settings(struct bq27xxx_device_info *di)
> +static void bq27xxx_battery_settings(struct bq27xxx_device_info *di)
>  {
>  	struct power_supply_battery_info info = {};
>  	unsigned int min, max;

Reviewed-by: Pali Rohár <pali.rohar@gmail.com>

-- 
Pali Rohár
pali.rohar@gmail.com

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] power: supply: bq27xxx: make bq27xxx_battery_settings static Colin King <colin.king@canonical.com> - 2017-05-03 12:50 +0200
  Re: [PATCH] power: supply: bq27xxx: make bq27xxx_battery_settings  static Pali Rohár <pali.rohar@gmail.com> - 2017-05-04 10:20 +0200
  Re: [PATCH] power: supply: bq27xxx: make bq27xxx_battery_settings  static Sebastian Reichel <sebastian.reichel@collabora.co.uk> - 2017-05-04 17:30 +0200

csiph-web