Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1632484 > unrolled thread
| Started by | Karim Eshapa <karim.eshapa@gmail.com> |
|---|---|
| First post | 2017-04-28 03:50 +0200 |
| Last post | 2017-05-01 16:00 +0200 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] drivers:net:ethernet:emulex:benet: Use time_before_eq for time comparison Karim Eshapa <karim.eshapa@gmail.com> - 2017-04-28 03:50 +0200
Re: [PATCH] drivers:net:ethernet:emulex:benet: Use time_before_eq for time comparison David Miller <davem@davemloft.net> - 2017-05-01 04:40 +0200
[PATCH] benet: Use time_before_eq for time comparison Karim Eshapa <karim.eshapa@gmail.com> - 2017-05-01 16:00 +0200
| From | Karim Eshapa <karim.eshapa@gmail.com> |
|---|---|
| Date | 2017-04-28 03:50 +0200 |
| Subject | [PATCH] drivers:net:ethernet:emulex:benet: Use time_before_eq for time comparison |
| Message-ID | <tB3cJ-Dx-3@gated-at.bofh.it> |
Use time_before_eq for time comparison more safe and dealing
with timer wrapping to be future-proof.
Signed-off-by: Karim Eshapa <kaim.eshapa@gmail.com>
---
drivers/net/ethernet/emulex/benet/be_main.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/emulex/benet/be_main.c b/drivers/net/ethernet/emulex/benet/be_main.c
index 6be3b9a..56d2368 100644
--- a/drivers/net/ethernet/emulex/benet/be_main.c
+++ b/drivers/net/ethernet/emulex/benet/be_main.c
@@ -5217,15 +5217,15 @@ static bool be_err_is_recoverable(struct be_adapter *adapter)
dev_err(&adapter->pdev->dev, "Recoverable HW error code: 0x%x\n",
ue_err_code);
- if (jiffies - err_rec->probe_time <= initial_idle_time) {
+ if (time_before_eq(jiffies - err_rec->probe_time, initial_idle_time)) {
dev_err(&adapter->pdev->dev,
"Cannot recover within %lu sec from driver load\n",
jiffies_to_msecs(initial_idle_time) / MSEC_PER_SEC);
return false;
}
- if (err_rec->last_recovery_time &&
- (jiffies - err_rec->last_recovery_time <= recovery_interval)) {
+ if (err_rec->last_recovery_time && time_before_eq(
+ jiffies - err_rec->last_recovery_time, recovery_interval)) {
dev_err(&adapter->pdev->dev,
"Cannot recover within %lu sec from last recovery\n",
jiffies_to_msecs(recovery_interval) / MSEC_PER_SEC);
--
2.7.4
[toc] | [next] | [standalone]
| From | David Miller <davem@davemloft.net> |
|---|---|
| Date | 2017-05-01 04:40 +0200 |
| Subject | Re: [PATCH] drivers:net:ethernet:emulex:benet: Use time_before_eq for time comparison |
| Message-ID | <tC9pM-36y-3@gated-at.bofh.it> |
| In reply to | #1632484 |
From: Karim Eshapa <karim.eshapa@gmail.com> Date: Fri, 28 Apr 2017 03:48:59 +0200 > Use time_before_eq for time comparison more safe and dealing > with timer wrapping to be future-proof. > > Signed-off-by: Karim Eshapa <kaim.eshapa@gmail.com> Subject line has way too many subsystem prefixes, simply "benet: " is sufficient. And in situations where multiple subsystem prefixes are appropriate, one must put a space after each one like "one: two: three: ". Thanks.
[toc] | [prev] | [next] | [standalone]
| From | Karim Eshapa <karim.eshapa@gmail.com> |
|---|---|
| Date | 2017-05-01 16:00 +0200 |
| Subject | [PATCH] benet: Use time_before_eq for time comparison |
| Message-ID | <tCk1P-1qB-3@gated-at.bofh.it> |
| In reply to | #1632484 |
Use time_before_eq for time comparison more safe and dealing
with timer wrapping to be future-proof.
Signed-off-by: Karim Eshapa <karim.eshapa@gmail.com>
---
drivers/net/ethernet/emulex/benet/be_main.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/emulex/benet/be_main.c b/drivers/net/ethernet/emulex/benet/be_main.c
index 6be3b9a..56d2368 100644
--- a/drivers/net/ethernet/emulex/benet/be_main.c
+++ b/drivers/net/ethernet/emulex/benet/be_main.c
@@ -5217,15 +5217,15 @@ static bool be_err_is_recoverable(struct be_adapter *adapter)
dev_err(&adapter->pdev->dev, "Recoverable HW error code: 0x%x\n",
ue_err_code);
- if (jiffies - err_rec->probe_time <= initial_idle_time) {
+ if (time_before_eq(jiffies - err_rec->probe_time, initial_idle_time)) {
dev_err(&adapter->pdev->dev,
"Cannot recover within %lu sec from driver load\n",
jiffies_to_msecs(initial_idle_time) / MSEC_PER_SEC);
return false;
}
- if (err_rec->last_recovery_time &&
- (jiffies - err_rec->last_recovery_time <= recovery_interval)) {
+ if (err_rec->last_recovery_time && time_before_eq(
+ jiffies - err_rec->last_recovery_time, recovery_interval)) {
dev_err(&adapter->pdev->dev,
"Cannot recover within %lu sec from last recovery\n",
jiffies_to_msecs(recovery_interval) / MSEC_PER_SEC);
--
2.7.4
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web