[PATCH] benet: Use time_before_eq for time comparison

From	Karim Eshapa <karim.eshapa@gmail.com>
Newsgroups	linux.kernel
Subject	[PATCH] benet: Use time_before_eq for time comparison
Date	2017-05-01 16:00 +0200
Message-ID	<tCk1P-1qB-3@gated-at.bofh.it> (permalink)
References	<tB3cJ-Dx-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Use time_before_eq for time comparison more safe and dealing
with timer wrapping to be future-proof.

Signed-off-by: Karim Eshapa <karim.eshapa@gmail.com>
---
 drivers/net/ethernet/emulex/benet/be_main.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/net/ethernet/emulex/benet/be_main.c b/drivers/net/ethernet/emulex/benet/be_main.c
index 6be3b9a..56d2368 100644
--- a/drivers/net/ethernet/emulex/benet/be_main.c
+++ b/drivers/net/ethernet/emulex/benet/be_main.c
@@ -5217,15 +5217,15 @@ static bool be_err_is_recoverable(struct be_adapter *adapter)
 	dev_err(&adapter->pdev->dev, "Recoverable HW error code: 0x%x\n",
 		ue_err_code);
 
-	if (jiffies - err_rec->probe_time <= initial_idle_time) {
+	if (time_before_eq(jiffies - err_rec->probe_time, initial_idle_time)) {
 		dev_err(&adapter->pdev->dev,
 			"Cannot recover within %lu sec from driver load\n",
 			jiffies_to_msecs(initial_idle_time) / MSEC_PER_SEC);
 		return false;
 	}
 
-	if (err_rec->last_recovery_time &&
-	    (jiffies - err_rec->last_recovery_time <= recovery_interval)) {
+	if (err_rec->last_recovery_time && time_before_eq(
+		jiffies - err_rec->last_recovery_time, recovery_interval)) {
 		dev_err(&adapter->pdev->dev,
 			"Cannot recover within %lu sec from last recovery\n",
 			jiffies_to_msecs(recovery_interval) / MSEC_PER_SEC);
-- 
2.7.4

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] drivers:net:ethernet:emulex:benet: Use time_before_eq for time comparison Karim Eshapa <karim.eshapa@gmail.com> - 2017-04-28 03:50 +0200
  Re: [PATCH] drivers:net:ethernet:emulex:benet: Use time_before_eq  for time comparison David Miller <davem@davemloft.net> - 2017-05-01 04:40 +0200
  [PATCH] benet: Use time_before_eq for time comparison Karim Eshapa <karim.eshapa@gmail.com> - 2017-05-01 16:00 +0200

csiph-web