Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1633604 > unrolled thread

Re: [PATCH RESEND 1/3 v4] drivers:power:twl4030-charger: don't check if battery is present

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH RESEND 1/3 v4] drivers:power:twl4030-charger: don't check  if battery is present Sebastian Reichel <sebastian.reichel@collabora.co.uk> - 2017-05-01 13:30 +0200
    Re: [PATCH RESEND 1/3 v4] drivers:power:twl4030-charger: don't check if battery is present "H. Nikolaus Schaller" <hns@goldelico.com> - 2017-05-03 14:30 +0200

#1633604 — Re: [PATCH RESEND 1/3 v4] drivers:power:twl4030-charger: don't check if battery is present

[Multipart message — attachments visible in raw view] — view raw

Hi,

On Fri, Apr 14, 2017 at 09:29:38PM +0200, H. Nikolaus Schaller wrote:
> We can't assume that the battery is or stays present after probing
> on devices with replaceable battery.
> 
> On some devices (e.g. GTA04 or OpenPanodra) it can be removed
> and even be hot swapped by the user while device continues to operate
> through external AC or USB power (as long as system power consumption
> remains below ca. 500mA as provided by USB). Under certain conditions
> it is possible to boot without battery.
> 
> So it makes no sense to check for this situation during probe and make
> the charger driver (and its status reports) completely non-operational if
> the battery can be inserted later.
> 
> Tested on: GTA04 and OpenPandora.
> 
> Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>

Thanks, queued.

-- Sebastian

[toc] | [next] | [standalone]

#1634947 — Re: [PATCH RESEND 1/3 v4] drivers:power:twl4030-charger: don't check if battery is present

[Multipart message — attachments visible in raw view] — view raw

> Am 01.05.2017 um 13:26 schrieb Sebastian Reichel <sebastian.reichel@collabora.co.uk>:
> 
> Hi,
> 
> On Fri, Apr 14, 2017 at 09:29:38PM +0200, H. Nikolaus Schaller wrote:
>> We can't assume that the battery is or stays present after probing
>> on devices with replaceable battery.
>> 
>> On some devices (e.g. GTA04 or OpenPanodra) it can be removed
>> and even be hot swapped by the user while device continues to operate
>> through external AC or USB power (as long as system power consumption
>> remains below ca. 500mA as provided by USB). Under certain conditions
>> it is possible to boot without battery.
>> 
>> So it makes no sense to check for this situation during probe and make
>> the charger driver (and its status reports) completely non-operational if
>> the battery can be inserted later.
>> 
>> Tested on: GTA04 and OpenPandora.
>> 
>> Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
> 
> Thanks, queued.

TNX,
Nikolaus

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web