Re: [PATCH RESEND 1/3 v4] drivers:power:twl4030-charger: don't check if battery is present

From	Sebastian Reichel <sebastian.reichel@collabora.co.uk>
Newsgroups	linux.kernel
Subject	Re: [PATCH RESEND 1/3 v4] drivers:power:twl4030-charger: don't check if battery is present
Date	2017-05-01 13:30 +0200
Message-ID	<tChGG-4X-5@gated-at.bofh.it> (permalink)
References	<twf4S-53V-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi,

On Fri, Apr 14, 2017 at 09:29:38PM +0200, H. Nikolaus Schaller wrote:
> We can't assume that the battery is or stays present after probing
> on devices with replaceable battery.
> 
> On some devices (e.g. GTA04 or OpenPanodra) it can be removed
> and even be hot swapped by the user while device continues to operate
> through external AC or USB power (as long as system power consumption
> remains below ca. 500mA as provided by USB). Under certain conditions
> it is possible to boot without battery.
> 
> So it makes no sense to check for this situation during probe and make
> the charger driver (and its status reports) completely non-operational if
> the battery can be inserted later.
> 
> Tested on: GTA04 and OpenPandora.
> 
> Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>

Thanks, queued.

-- Sebastian

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH RESEND 1/3 v4] drivers:power:twl4030-charger: don't check  if battery is present Sebastian Reichel <sebastian.reichel@collabora.co.uk> - 2017-05-01 13:30 +0200
  Re: [PATCH RESEND 1/3 v4] drivers:power:twl4030-charger: don't check if battery is present "H. Nikolaus Schaller" <hns@goldelico.com> - 2017-05-03 14:30 +0200

csiph-web