Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1632987 > unrolled thread

[PATCH] staging: iio: isl29028: add isl29030 support

Back to article view | Back to linux.kernel

Contents

  [PATCH] staging: iio: isl29028: add isl29030 support Sebastian Reichel <sebastian.reichel@collabora.co.uk> - 2017-04-28 18:00 +0200
    Re: [PATCH] staging: iio: isl29028: add isl29030 support Brian Masney <masneyb@onstation.org> - 2017-04-28 18:20 +0200
      Re: [PATCH] staging: iio: isl29028: add isl29030 support Jonathan Cameron <jic23@kernel.org> - 2017-04-30 18:30 +0200
        Re: [PATCH] staging: iio: isl29028: add isl29030 support Sebastian Reichel <sebastian.reichel@collabora.co.uk> - 2017-04-30 21:50 +0200

#1632987 — [PATCH] staging: iio: isl29028: add isl29030 support

isl29030 is basically the same chip. The only difference
is the chip's first pin. For isl29028 its named ADDR0 and
can be used to change the chip's i2c address. For isl29030
on the other hand that pin is named Ials and is an analog
current output proportional to ALS/IR. This change is
irrelevant for the Linux driver.

This has been tested on Motorola Droid 4.

Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
---
 Documentation/devicetree/bindings/i2c/trivial-devices.txt | 1 +
 drivers/staging/iio/light/isl29028.c                      | 6 ++++++
 2 files changed, 7 insertions(+)

diff --git a/Documentation/devicetree/bindings/i2c/trivial-devices.txt b/Documentation/devicetree/bindings/i2c/trivial-devices.txt
index ad10fbe61562..010e2ac43f62 100644
--- a/Documentation/devicetree/bindings/i2c/trivial-devices.txt
+++ b/Documentation/devicetree/bindings/i2c/trivial-devices.txt
@@ -55,6 +55,7 @@ gmt,g751		G751: Digital Temperature Sensor and Thermal Watchdog with Two-Wire In
 infineon,slb9635tt	Infineon SLB9635 (Soft-) I2C TPM (old protocol, max 100khz)
 infineon,slb9645tt	Infineon SLB9645 I2C TPM (new protocol, max 400khz)
 isil,isl29028		Intersil ISL29028 Ambient Light and Proximity Sensor
+isil,isl29030		Intersil ISL29030 Ambient Light and Proximity Sensor
 maxim,ds1050		5 Bit Programmable, Pulse-Width Modulator
 maxim,max1237		Low-Power, 4-/12-Channel, 2-Wire Serial, 12-Bit ADCs
 maxim,max6625		9-Bit/12-Bit Temperature Sensors with I²C-Compatible Serial Interface
diff --git a/drivers/staging/iio/light/isl29028.c b/drivers/staging/iio/light/isl29028.c
index 6bb6d37cc7d1..564a62e54b05 100644
--- a/drivers/staging/iio/light/isl29028.c
+++ b/drivers/staging/iio/light/isl29028.c
@@ -15,6 +15,10 @@
  *
  * You should have received a copy of the GNU General Public License
  * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ *
+ * Datasheets:
+ *  - http://www.intersil.com/content/dam/Intersil/documents/isl2/isl29028.pdf
+ *  - http://www.intersil.com/content/dam/Intersil/documents/isl2/isl29030.pdf
  */
 
 #include <linux/module.h>
@@ -651,6 +655,7 @@ static const struct dev_pm_ops isl29028_pm_ops = {
 
 static const struct i2c_device_id isl29028_id[] = {
 	{"isl29028", 0},
+	{"isl29030", 0},
 	{}
 };
 MODULE_DEVICE_TABLE(i2c, isl29028_id);
@@ -658,6 +663,7 @@ MODULE_DEVICE_TABLE(i2c, isl29028_id);
 static const struct of_device_id isl29028_of_match[] = {
 	{ .compatible = "isl,isl29028", }, /* for backward compat., don't use */
 	{ .compatible = "isil,isl29028", },
+	{ .compatible = "isil,isl29030", },
 	{ },
 };
 MODULE_DEVICE_TABLE(of, isl29028_of_match);
-- 
2.11.0

[toc] | [next] | [standalone]

#1632997

On Fri, Apr 28, 2017 at 05:55:58PM +0200, Sebastian Reichel wrote:
> isl29030 is basically the same chip. The only difference
> is the chip's first pin. For isl29028 its named ADDR0 and
> can be used to change the chip's i2c address. For isl29030
> on the other hand that pin is named Ials and is an analog
> current output proportional to ALS/IR. This change is
> irrelevant for the Linux driver.
> 
> This has been tested on Motorola Droid 4.
> 
> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
> ---
>  Documentation/devicetree/bindings/i2c/trivial-devices.txt | 1 +
>  drivers/staging/iio/light/isl29028.c                      | 6 ++++++
>  2 files changed, 7 insertions(+)

Hi Sebastian,

I moved this driver out of the staging directory earlier this week.
You'll need to base your patch off of IIO testing:

https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git/log/?h=testing

Your patch should apply cleanly once you update the file path.

Brian

[toc] | [prev] | [next] | [standalone]

#1633453

On 28/04/17 17:17, Brian Masney wrote:
> On Fri, Apr 28, 2017 at 05:55:58PM +0200, Sebastian Reichel wrote:
>> isl29030 is basically the same chip. The only difference
>> is the chip's first pin. For isl29028 its named ADDR0 and
>> can be used to change the chip's i2c address. For isl29030
>> on the other hand that pin is named Ials and is an analog
>> current output proportional to ALS/IR. This change is
>> irrelevant for the Linux driver.
>>
>> This has been tested on Motorola Droid 4.
>>
>> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
>> ---
>>  Documentation/devicetree/bindings/i2c/trivial-devices.txt | 1 +
>>  drivers/staging/iio/light/isl29028.c                      | 6 ++++++
>>  2 files changed, 7 insertions(+)
> 
> Hi Sebastian,
> 
> I moved this driver out of the staging directory earlier this week.
> You'll need to base your patch off of IIO testing:
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git/log/?h=testing
> 
> Your patch should apply cleanly once you update the file path.
I did it rather than having this bounce around for a trivial rebase.

Applied to the togreg branch of iio.git and pushed out as testing of
the autobuilders to play with it.

Thanks,

Jonathan
> 
> Brian
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

[toc] | [prev] | [next] | [standalone]

#1633486

[Multipart message — attachments visible in raw view] — view raw

Hi,

On Sun, Apr 30, 2017 at 05:27:07PM +0100, Jonathan Cameron wrote:
> On 28/04/17 17:17, Brian Masney wrote:
> > On Fri, Apr 28, 2017 at 05:55:58PM +0200, Sebastian Reichel wrote:
> >> isl29030 is basically the same chip. The only difference
> >> is the chip's first pin. For isl29028 its named ADDR0 and
> >> can be used to change the chip's i2c address. For isl29030
> >> on the other hand that pin is named Ials and is an analog
> >> current output proportional to ALS/IR. This change is
> >> irrelevant for the Linux driver.
> >>
> >> This has been tested on Motorola Droid 4.
> >>
> >> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
> >> ---
> >>  Documentation/devicetree/bindings/i2c/trivial-devices.txt | 1 +
> >>  drivers/staging/iio/light/isl29028.c                      | 6 ++++++
> >>  2 files changed, 7 insertions(+)
> > 
> > Hi Sebastian,
> > 
> > I moved this driver out of the staging directory earlier this week.
> > You'll need to base your patch off of IIO testing:
> > 
> > https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git/log/?h=testing
> > 
> > Your patch should apply cleanly once you update the file path.
> I did it rather than having this bounce around for a trivial rebase.
> 
> Applied to the togreg branch of iio.git and pushed out as testing of
> the autobuilders to play with it.

Thanks.

-- Sebastian

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web