Re: [PATCH] staging: iio: isl29028: add isl29030 support

From	Jonathan Cameron <jic23@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] staging: iio: isl29028: add isl29030 support
Date	2017-04-30 18:30 +0200
Message-ID	<tBZTs-5qZ-9@gated-at.bofh.it> (permalink)
References	<tBgtj-Zx-1@gated-at.bofh.it> <tBgMF-1o8-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 28/04/17 17:17, Brian Masney wrote:
> On Fri, Apr 28, 2017 at 05:55:58PM +0200, Sebastian Reichel wrote:
>> isl29030 is basically the same chip. The only difference
>> is the chip's first pin. For isl29028 its named ADDR0 and
>> can be used to change the chip's i2c address. For isl29030
>> on the other hand that pin is named Ials and is an analog
>> current output proportional to ALS/IR. This change is
>> irrelevant for the Linux driver.
>>
>> This has been tested on Motorola Droid 4.
>>
>> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
>> ---
>>  Documentation/devicetree/bindings/i2c/trivial-devices.txt | 1 +
>>  drivers/staging/iio/light/isl29028.c                      | 6 ++++++
>>  2 files changed, 7 insertions(+)
> 
> Hi Sebastian,
> 
> I moved this driver out of the staging directory earlier this week.
> You'll need to base your patch off of IIO testing:
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git/log/?h=testing
> 
> Your patch should apply cleanly once you update the file path.
I did it rather than having this bounce around for a trivial rebase.

Applied to the togreg branch of iio.git and pushed out as testing of
the autobuilders to play with it.

Thanks,

Jonathan
> 
> Brian
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

Thread

[PATCH] staging: iio: isl29028: add isl29030 support Sebastian Reichel <sebastian.reichel@collabora.co.uk> - 2017-04-28 18:00 +0200
  Re: [PATCH] staging: iio: isl29028: add isl29030 support Brian Masney <masneyb@onstation.org> - 2017-04-28 18:20 +0200
    Re: [PATCH] staging: iio: isl29028: add isl29030 support Jonathan Cameron <jic23@kernel.org> - 2017-04-30 18:30 +0200
      Re: [PATCH] staging: iio: isl29028: add isl29030 support Sebastian Reichel <sebastian.reichel@collabora.co.uk> - 2017-04-30 21:50 +0200

csiph-web