Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1632790 > unrolled thread
| Started by | Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
|---|---|
| First post | 2017-04-28 12:40 +0200 |
| Last post | 2017-04-28 13:00 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH] staging: rtl8192u: Fix sparse warning Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-04-28 12:40 +0200
Re: [PATCH] staging: rtl8192u: Fix sparse warning Marcos Paulo de Souza <marcos.souza.org@gmail.com> - 2017-04-28 13:00 +0200
| From | Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
|---|---|
| Date | 2017-04-28 12:40 +0200 |
| Subject | Re: [PATCH] staging: rtl8192u: Fix sparse warning |
| Message-ID | <tBbtD-64f-15@gated-at.bofh.it> |
On Sun, Apr 23, 2017 at 05:51:17PM -0300, Marcos Paulo de Souza wrote: > Fix the following sparse warning: > rtl8192u/ieee80211/ieee80211_rx.c:1489:45: warning: incorrect type in assignment (different base types) > rtl8192u/ieee80211/ieee80211_rx.c:1489:45: expected restricted __le16 <noident> > rtl8192u/ieee80211/ieee80211_rx.c:1489:45: got unsigned short [unsigned] [usertype] <noident> > > Since ac_params->tx_op_limit is already an __le16, we shouldn't convert it into cpu type. > > Signed-off-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com> > --- > > Sorry, I don't have the hardware to test, so please review and tell me if I'm wrong in this one! Patch doesn't apply to my tree at all :(
[toc] | [next] | [standalone]
| From | Marcos Paulo de Souza <marcos.souza.org@gmail.com> |
|---|---|
| Date | 2017-04-28 13:00 +0200 |
| Message-ID | <tBbMZ-6bT-7@gated-at.bofh.it> |
| In reply to | #1632790 |
On Fri, Apr 28, 2017 at 12:29:55PM +0200, Greg Kroah-Hartman wrote: > On Sun, Apr 23, 2017 at 05:51:17PM -0300, Marcos Paulo de Souza wrote: > > Fix the following sparse warning: > > rtl8192u/ieee80211/ieee80211_rx.c:1489:45: warning: incorrect type in assignment (different base types) > > rtl8192u/ieee80211/ieee80211_rx.c:1489:45: expected restricted __le16 <noident> > > rtl8192u/ieee80211/ieee80211_rx.c:1489:45: got unsigned short [unsigned] [usertype] <noident> > > > > Since ac_params->tx_op_limit is already an __le16, we shouldn't convert it into cpu type. > > > > Signed-off-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com> > > --- > > > > Sorry, I don't have the hardware to test, so please review and tell me if I'm wrong in this one! > > Patch doesn't apply to my tree at all :( My patch was based on master... my apologies. Will resend based on staging-next. -- Thanks, Marcos
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web