Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1632799

Re: [PATCH] staging: rtl8192u: Fix sparse warning

Show all headers | View raw

On Fri, Apr 28, 2017 at 12:29:55PM +0200, Greg Kroah-Hartman wrote:
> On Sun, Apr 23, 2017 at 05:51:17PM -0300, Marcos Paulo de Souza wrote:
> > Fix the following sparse warning:
> > rtl8192u/ieee80211/ieee80211_rx.c:1489:45: warning: incorrect type in assignment (different base types)
> > rtl8192u/ieee80211/ieee80211_rx.c:1489:45:    expected restricted __le16 <noident>
> > rtl8192u/ieee80211/ieee80211_rx.c:1489:45:    got unsigned short [unsigned] [usertype] <noident>
> > 
> > Since ac_params->tx_op_limit is already an __le16, we shouldn't convert it into cpu type.
> > 
> > Signed-off-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
> > ---
> > 
> >  Sorry, I don't have the hardware to test, so please review and tell me if I'm wrong in this one!
> 
> Patch doesn't apply to my tree at all :(

My patch was based on master... my apologies. Will resend based on
staging-next.

-- 
Thanks,
	Marcos

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH] staging: rtl8192u: Fix sparse warning Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-04-28 12:40 +0200
  Re: [PATCH] staging: rtl8192u: Fix sparse warning Marcos Paulo de Souza <marcos.souza.org@gmail.com> - 2017-04-28 13:00 +0200

csiph-web