Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1632553 > unrolled thread
| Started by | Michael Mera <dev@michaelmera.com> |
|---|---|
| First post | 2017-04-28 08:30 +0200 |
| Last post | 2017-05-10 01:50 +0200 |
| Articles | 10 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] staging: speakup: fix wrong code indent Michael Mera <dev@michaelmera.com> - 2017-04-28 08:30 +0200
Re: [PATCH] staging: speakup: fix wrong code indent Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-04-28 09:20 +0200
[PATCH v2] staging: speakup: fix wrong code indent Michael Mera <dev@michaelmera.com> - 2017-04-28 10:50 +0200
Re: [PATCH v2] staging: speakup: fix wrong code indent Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-04-28 11:10 +0200
Re: [PATCH v2] staging: speakup: fix wrong code indent Michael Mera <dev@michaelmera.com> - 2017-04-28 11:20 +0200
Re: [PATCH v2] staging: speakup: fix wrong code indent Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-04-28 11:40 +0200
[PATCH v3] staging: speakup: fix wrong code indent Michael Mera <dev@michaelmera.com> - 2017-04-28 16:50 +0200
Re: [PATCH v3] staging: speakup: fix wrong code indent Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-04-28 18:00 +0200
Re: [PATCH v3] staging: speakup: fix wrong code indent Michael Mera <dev@michaelmera.com> - 2017-04-29 03:30 +0200
[PATCH v4] staging: speakup: fix unnecessary long line Michael Mera <dev@michaelmera.com> - 2017-05-10 01:50 +0200
| From | Michael Mera <dev@michaelmera.com> |
|---|---|
| Date | 2017-04-28 08:30 +0200 |
| Subject | [PATCH] staging: speakup: fix wrong code indent |
| Message-ID | <tB7zH-3BN-5@gated-at.bofh.it> |
Remove unecessary multiline comment, fixes checkpatch messages: ERROR: code indent should use tabs where possible WARNING: Block comments should align the * on each line Signed-off-by: Michael Mera <dev@michaelmera.com> --- drivers/staging/speakup/speakup_decpc.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/speakup/speakup_decpc.c b/drivers/staging/speakup/speakup_decpc.c index 6bf38e49a96d..94ca6987f71b 100644 --- a/drivers/staging/speakup/speakup_decpc.c +++ b/drivers/staging/speakup/speakup_decpc.c @@ -84,9 +84,7 @@ #define CTRL_last_index 0x0b00 /* get last index spoken */ #define CTRL_io_priority 0x0c00 /* change i/o priority */ #define CTRL_free_mem 0x0d00 /* get free paragraphs on module */ -#define CTRL_get_lang 0x0e00 /* return bit mask of loaded - * languages - */ +#define CTRL_get_lang 0x0e00 /* return bitmask of loaded languages */ #define CMD_test 0x2000 /* self-test request */ #define TEST_mask 0x0F00 /* isolate test field */ #define TEST_null 0x0000 /* no test requested */ -- 2.9.3
[toc] | [next] | [standalone]
| From | Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
|---|---|
| Date | 2017-04-28 09:20 +0200 |
| Message-ID | <tB8m5-4bc-7@gated-at.bofh.it> |
| In reply to | #1632553 |
On Fri, Apr 28, 2017 at 03:20:24PM +0900, Michael Mera wrote: > Remove unecessary multiline comment, fixes checkpatch messages: > ERROR: code indent should use tabs where possible > WARNING: Block comments should align the * on each line > > Signed-off-by: Michael Mera <dev@michaelmera.com> > --- > drivers/staging/speakup/speakup_decpc.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/staging/speakup/speakup_decpc.c b/drivers/staging/speakup/speakup_decpc.c > index 6bf38e49a96d..94ca6987f71b 100644 > --- a/drivers/staging/speakup/speakup_decpc.c > +++ b/drivers/staging/speakup/speakup_decpc.c > @@ -84,9 +84,7 @@ > #define CTRL_last_index 0x0b00 /* get last index spoken */ > #define CTRL_io_priority 0x0c00 /* change i/o priority */ > #define CTRL_free_mem 0x0d00 /* get free paragraphs on module */ > -#define CTRL_get_lang 0x0e00 /* return bit mask of loaded > - * languages > - */ > +#define CTRL_get_lang 0x0e00 /* return bitmask of loaded languages */ And now you have a different coding style warning :( Sorry, you can't replace one for another. greg k-h
[toc] | [prev] | [next] | [standalone]
| From | Michael Mera <dev@michaelmera.com> |
|---|---|
| Date | 2017-04-28 10:50 +0200 |
| Subject | [PATCH v2] staging: speakup: fix wrong code indent |
| Message-ID | <tB9Lb-4Zj-5@gated-at.bofh.it> |
| In reply to | #1632570 |
Remove unnecessary multiline comment, fixes checkpatch messages: ERROR: code indent should use tabs where possible WARNING: Block comments should align the * on each line Signed-off-by: Michael Mera <dev@michaelmera.com> --- drivers/staging/speakup/speakup_decpc.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/speakup/speakup_decpc.c b/drivers/staging/speakup/speakup_decpc.c index 6bf38e49a96d..94ca6987f71b 100644 --- a/drivers/staging/speakup/speakup_decpc.c +++ b/drivers/staging/speakup/speakup_decpc.c @@ -84,9 +84,7 @@ #define CTRL_last_index 0x0b00 /* get last index spoken */ #define CTRL_io_priority 0x0c00 /* change i/o priority */ #define CTRL_free_mem 0x0d00 /* get free paragraphs on module */ -#define CTRL_get_lang 0x0e00 /* return bit mask of loaded - * languages - */ +#define CTRL_get_lang 0x0e00 /* return bitmask of loaded languages */ #define CMD_test 0x2000 /* self-test request */ #define TEST_mask 0x0F00 /* isolate test field */ #define TEST_null 0x0000 /* no test requested */ -- 2.9.3
[toc] | [prev] | [next] | [standalone]
| From | Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
|---|---|
| Date | 2017-04-28 11:10 +0200 |
| Subject | Re: [PATCH v2] staging: speakup: fix wrong code indent |
| Message-ID | <tBa4y-5m0-21@gated-at.bofh.it> |
| In reply to | #1632660 |
On Fri, Apr 28, 2017 at 05:46:07PM +0900, Michael Mera wrote: > Remove unnecessary multiline comment, fixes checkpatch messages: > ERROR: code indent should use tabs where possible > WARNING: Block comments should align the * on each line > > Signed-off-by: Michael Mera <dev@michaelmera.com> > --- > drivers/staging/speakup/speakup_decpc.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) What changed from v1? That needs to go below the --- line. And I think my previous email still is relevant here...
[toc] | [prev] | [next] | [standalone]
| From | Michael Mera <dev@michaelmera.com> |
|---|---|
| Date | 2017-04-28 11:20 +0200 |
| Subject | Re: [PATCH v2] staging: speakup: fix wrong code indent |
| Message-ID | <tBaee-5ps-15@gated-at.bofh.it> |
| In reply to | #1632707 |
Greg Kroah-Hartman <gregkh@linuxfoundation.org> writes: > On Fri, Apr 28, 2017 at 05:46:07PM +0900, Michael Mera wrote: >> Remove unnecessary multiline comment, fixes checkpatch messages: >> ERROR: code indent should use tabs where possible >> WARNING: Block comments should align the * on each line >> >> Signed-off-by: Michael Mera <dev@michaelmera.com> >> --- >> drivers/staging/speakup/speakup_decpc.c | 4 +--- >> 1 file changed, 1 insertion(+), 3 deletions(-) > > What changed from v1? That needs to go below the --- line. Oh. Sorry. I fixed the spelling of the patch message, since I though that was the problem you detected but... > > And I think my previous email still is relevant here... ... apparently not. I double checked the patch with 'checkpatch --strict' and it does not detect any problem this time. Sorry if I missed something obvious, I am quite new to this, but could you give me some additional hint about the problem.
[toc] | [prev] | [next] | [standalone]
| From | Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
|---|---|
| Date | 2017-04-28 11:40 +0200 |
| Subject | Re: [PATCH v2] staging: speakup: fix wrong code indent |
| Message-ID | <tBaxA-5vx-5@gated-at.bofh.it> |
| In reply to | #1632714 |
On Fri, Apr 28, 2017 at 06:11:04PM +0900, Michael Mera wrote: > Greg Kroah-Hartman <gregkh@linuxfoundation.org> writes: > > > On Fri, Apr 28, 2017 at 05:46:07PM +0900, Michael Mera wrote: > >> Remove unnecessary multiline comment, fixes checkpatch messages: > >> ERROR: code indent should use tabs where possible > >> WARNING: Block comments should align the * on each line > >> > >> Signed-off-by: Michael Mera <dev@michaelmera.com> > >> --- > >> drivers/staging/speakup/speakup_decpc.c | 4 +--- > >> 1 file changed, 1 insertion(+), 3 deletions(-) > > > > What changed from v1? That needs to go below the --- line. > > Oh. Sorry. I fixed the spelling of the patch message, since I > though that was the problem you detected but... > > > > > And I think my previous email still is relevant here... > > ... apparently not. I double checked the patch with 'checkpatch --strict' > and it does not detect any problem this time. > > Sorry if I missed something obvious, I am quite new to this, but could > you give me some additional hint about the problem. Isn't the line now too long? Anyway, please resend with at least the properly version information. thanks, greg k-h
[toc] | [prev] | [next] | [standalone]
| From | Michael Mera <dev@michaelmera.com> |
|---|---|
| Date | 2017-04-28 16:50 +0200 |
| Subject | [PATCH v3] staging: speakup: fix wrong code indent |
| Message-ID | <tBfnz-f6-3@gated-at.bofh.it> |
| In reply to | #1632735 |
Fix checkpatch messages:
ERROR: code indent should use tabs where possible
WARNING: Block comments should align the * on each line
Changes:
- replace unnecessary multiline comment by a single line comment
- change "bit mask" for "bitmask" to have a line shorter than 80
characters
Signed-off-by: Michael Mera <dev@michaelmera.com>
---
v2 -> v3:
- add missing changes descriptions
- improve patch message to make it more clear what changed
v1 -> v2:
- fix typo in patch description message
drivers/staging/speakup/speakup_decpc.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/staging/speakup/speakup_decpc.c b/drivers/staging/speakup/speakup_decpc.c
index 6bf38e49a96d..94ca6987f71b 100644
--- a/drivers/staging/speakup/speakup_decpc.c
+++ b/drivers/staging/speakup/speakup_decpc.c
@@ -84,9 +84,7 @@
#define CTRL_last_index 0x0b00 /* get last index spoken */
#define CTRL_io_priority 0x0c00 /* change i/o priority */
#define CTRL_free_mem 0x0d00 /* get free paragraphs on module */
-#define CTRL_get_lang 0x0e00 /* return bit mask of loaded
- * languages
- */
+#define CTRL_get_lang 0x0e00 /* return bitmask of loaded languages */
#define CMD_test 0x2000 /* self-test request */
#define TEST_mask 0x0F00 /* isolate test field */
#define TEST_null 0x0000 /* no test requested */
--
2.9.3
[toc] | [prev] | [next] | [standalone]
| From | Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
|---|---|
| Date | 2017-04-28 18:00 +0200 |
| Subject | Re: [PATCH v3] staging: speakup: fix wrong code indent |
| Message-ID | <tBgtk-Zx-9@gated-at.bofh.it> |
| In reply to | #1632945 |
On Fri, Apr 28, 2017 at 11:43:26PM +0900, Michael Mera wrote: > Fix checkpatch messages: > ERROR: code indent should use tabs where possible > WARNING: Block comments should align the * on each line > > Changes: > - replace unnecessary multiline comment by a single line comment > - change "bit mask" for "bitmask" to have a line shorter than 80 > characters > > Signed-off-by: Michael Mera <dev@michaelmera.com> > --- > > v2 -> v3: > - add missing changes descriptions > - improve patch message to make it more clear what changed This patch doesn't apply to my tree at all, what tree/branch did you make it against? thanks, greg k-h
[toc] | [prev] | [next] | [standalone]
| From | Michael Mera <dev@michaelmera.com> |
|---|---|
| Date | 2017-04-29 03:30 +0200 |
| Subject | Re: [PATCH v3] staging: speakup: fix wrong code indent |
| Message-ID | <tBpmV-7w6-1@gated-at.bofh.it> |
| In reply to | #1632990 |
Greg Kroah-Hartman <gregkh@linuxfoundation.org> writes: > This patch doesn't apply to my tree at all, what tree/branch did you > make it against? From the 'T:' line in MAINTAINER at STAGING SUBSYSTEM, I thought that I should base changes on: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git Since there was no branch indication unlike some other lines, I worked on master. Now, given your remark I found your blog post where you ask to base the changes on linux-next. Sorry. Part of the patch is still relevant, so I intend to submit a v4. If that is ok with you. Thank you, Michael Mera
[toc] | [prev] | [next] | [standalone]
| From | Michael Mera <dev@michaelmera.com> |
|---|---|
| Date | 2017-05-10 01:50 +0200 |
| Subject | [PATCH v4] staging: speakup: fix unnecessary long line |
| Message-ID | <tFn3b-i8-13@gated-at.bofh.it> |
| In reply to | #1633215 |
Fix checkpatch message: WARNING: line over 80 characters Change "bit mask" for "bitmask" to have a line shorter than 80 characters. Signed-off-by: Michael Mera <dev@michaelmera.com> --- v3 -> v4: - base changes on linux-next rather than some random tree - reduce scope of the patch (already partially solved) - adapted message accordingly v2 -> v3: - add missing changes descriptions - improve patch message to make it more clear what changed v1 -> v2: - fix typo in patch description message drivers/staging/speakup/speakup_decpc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/speakup/speakup_decpc.c b/drivers/staging/speakup/speakup_decpc.c index 5d22c3b7edd4..7a8df7dc1e38 100644 --- a/drivers/staging/speakup/speakup_decpc.c +++ b/drivers/staging/speakup/speakup_decpc.c @@ -84,7 +84,7 @@ #define CTRL_last_index 0x0b00 /* get last index spoken */ #define CTRL_io_priority 0x0c00 /* change i/o priority */ #define CTRL_free_mem 0x0d00 /* get free paragraphs on module */ -#define CTRL_get_lang 0x0e00 /* return bit mask of loaded languages */ +#define CTRL_get_lang 0x0e00 /* return bitmask of loaded languages */ #define CMD_test 0x2000 /* self-test request */ #define TEST_mask 0x0F00 /* isolate test field */ #define TEST_null 0x0000 /* no test requested */ -- 2.9.3
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web