Re: [PATCH v2] staging: speakup: fix wrong code indent

From	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] staging: speakup: fix wrong code indent
Date	2017-04-28 11:40 +0200
Message-ID	<tBaxA-5vx-5@gated-at.bofh.it> (permalink)
References	<tB8m5-4bc-7@gated-at.bofh.it> <tB9Lb-4Zj-5@gated-at.bofh.it> <tBa4y-5m0-21@gated-at.bofh.it> <tBaee-5ps-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Apr 28, 2017 at 06:11:04PM +0900, Michael Mera wrote:
> Greg Kroah-Hartman <gregkh@linuxfoundation.org> writes:
> 
> > On Fri, Apr 28, 2017 at 05:46:07PM +0900, Michael Mera wrote:
> >> Remove unnecessary multiline comment, fixes checkpatch messages:
> >> ERROR: code indent should use tabs where possible
> >> WARNING: Block comments should align the * on each line
> >> 
> >> Signed-off-by: Michael Mera <dev@michaelmera.com>
> >> ---
> >>  drivers/staging/speakup/speakup_decpc.c | 4 +---
> >>  1 file changed, 1 insertion(+), 3 deletions(-)
> >
> > What changed from v1?  That needs to go below the --- line.
> 
> Oh. Sorry. I fixed the spelling of the patch message, since I
> though that was the problem you detected but...
> 
> >
> > And I think my previous email still is relevant here...
> 
> ... apparently not. I double checked the patch with 'checkpatch --strict'
> and it does not detect any problem this time.
> 
> Sorry if I missed something obvious, I am quite new to this, but could
> you give me some additional hint about the problem.

Isn't the line now too long?

Anyway, please resend with at least the properly version information.

thanks,

greg k-h

Thread

[PATCH] staging: speakup: fix wrong code indent Michael Mera <dev@michaelmera.com> - 2017-04-28 08:30 +0200
  Re: [PATCH] staging: speakup: fix wrong code indent Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-04-28 09:20 +0200
    [PATCH v2] staging: speakup: fix wrong code indent Michael Mera <dev@michaelmera.com> - 2017-04-28 10:50 +0200
      Re: [PATCH v2] staging: speakup: fix wrong code indent Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-04-28 11:10 +0200
        Re: [PATCH v2] staging: speakup: fix wrong code indent Michael Mera <dev@michaelmera.com> - 2017-04-28 11:20 +0200
          Re: [PATCH v2] staging: speakup: fix wrong code indent Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-04-28 11:40 +0200
            [PATCH v3] staging: speakup: fix wrong code indent Michael Mera <dev@michaelmera.com> - 2017-04-28 16:50 +0200
              Re: [PATCH v3] staging: speakup: fix wrong code indent Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-04-28 18:00 +0200
                Re: [PATCH v3] staging: speakup: fix wrong code indent Michael Mera <dev@michaelmera.com> - 2017-04-29 03:30 +0200
                [PATCH v4] staging: speakup: fix unnecessary long line Michael Mera <dev@michaelmera.com> - 2017-05-10 01:50 +0200

csiph-web