Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1632051 > unrolled thread
| Started by | Pavel Machek <pavel@ucw.cz> |
|---|---|
| First post | 2017-04-27 14:00 +0200 |
| Last post | 2017-04-27 14:50 +0200 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH v3 09/29] x86: assembly, use DATA_SIMPLE for data Pavel Machek <pavel@ucw.cz> - 2017-04-27 14:00 +0200
Re: [PATCH v3 09/29] x86: assembly, use DATA_SIMPLE for data Jiri Slaby <jslaby@suse.cz> - 2017-04-27 14:40 +0200
Re: [PATCH v3 09/29] x86: assembly, use DATA_SIMPLE for data Pavel Machek <pavel@ucw.cz> - 2017-04-27 14:50 +0200
| From | Pavel Machek <pavel@ucw.cz> |
|---|---|
| Date | 2017-04-27 14:00 +0200 |
| Subject | Re: [PATCH v3 09/29] x86: assembly, use DATA_SIMPLE for data |
| Message-ID | <tAQfv-8w0-15@gated-at.bofh.it> |
[Multipart message — attachments visible in raw view] — view raw
Hi! > @@ -91,11 +91,11 @@ ENDPROC(do_suspend_lowlevel) > > .data > ALIGN > -ENTRY(saved_magic) .long 0 > -ENTRY(saved_eip) .long 0 > +SYM_DATA_SIMPLE(saved_magic, .long 0) > +SYM_DATA_SIMPLE_LOCAL(saved_eip, .long 0) > > # saved registers > -saved_idt: .long 0,0 > -saved_ldt: .long 0 > -saved_tss: .long 0 > +SYM_DATA_SIMPLE_LOCAL(saved_idt, .long 0,0) > +SYM_DATA_SIMPLE_LOCAL(saved_ldt, .long 0) > +SYM_DATA_SIMPLE_LOCAL(saved_tss, .long 0) Do we really need to mark local data like that? It complicates the source code a bit... Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[toc] | [next] | [standalone]
| From | Jiri Slaby <jslaby@suse.cz> |
|---|---|
| Date | 2017-04-27 14:40 +0200 |
| Message-ID | <tAQSe-Bq-23@gated-at.bofh.it> |
| In reply to | #1632051 |
[Multipart message — attachments visible in raw view] — view raw
Hi, On 04/27/2017, 01:53 PM, Pavel Machek wrote: >> @@ -91,11 +91,11 @@ ENDPROC(do_suspend_lowlevel) >> >> .data >> ALIGN >> -ENTRY(saved_magic) .long 0 >> -ENTRY(saved_eip) .long 0 >> +SYM_DATA_SIMPLE(saved_magic, .long 0) >> +SYM_DATA_SIMPLE_LOCAL(saved_eip, .long 0) >> >> # saved registers >> -saved_idt: .long 0,0 >> -saved_ldt: .long 0 >> -saved_tss: .long 0 >> +SYM_DATA_SIMPLE_LOCAL(saved_idt, .long 0,0) >> +SYM_DATA_SIMPLE_LOCAL(saved_ldt, .long 0) >> +SYM_DATA_SIMPLE_LOCAL(saved_tss, .long 0) > > Do we really need to mark local data like that? It complicates the > source code a bit... Not really -- if the preferred way is not to annotate local symbols, I can indeed remove that. thanks, -- js suse labs
[toc] | [prev] | [next] | [standalone]
| From | Pavel Machek <pavel@ucw.cz> |
|---|---|
| Date | 2017-04-27 14:50 +0200 |
| Message-ID | <tAR1U-F6-15@gated-at.bofh.it> |
| In reply to | #1632078 |
[Multipart message — attachments visible in raw view] — view raw
On Thu 2017-04-27 14:30:05, Jiri Slaby wrote: > Hi, > > On 04/27/2017, 01:53 PM, Pavel Machek wrote: > >> @@ -91,11 +91,11 @@ ENDPROC(do_suspend_lowlevel) > >> > >> .data > >> ALIGN > >> -ENTRY(saved_magic) .long 0 > >> -ENTRY(saved_eip) .long 0 > >> +SYM_DATA_SIMPLE(saved_magic, .long 0) > >> +SYM_DATA_SIMPLE_LOCAL(saved_eip, .long 0) > >> > >> # saved registers > >> -saved_idt: .long 0,0 > >> -saved_ldt: .long 0 > >> -saved_tss: .long 0 > >> +SYM_DATA_SIMPLE_LOCAL(saved_idt, .long 0,0) > >> +SYM_DATA_SIMPLE_LOCAL(saved_ldt, .long 0) > >> +SYM_DATA_SIMPLE_LOCAL(saved_tss, .long 0) > > > > Do we really need to mark local data like that? It complicates the > > source code a bit... > > Not really -- if the preferred way is not to annotate local symbols, I > can indeed remove that. I'd prefer that ;-). Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web