Groups > linux.kernel > #1632051

Re: [PATCH v3 09/29] x86: assembly, use DATA_SIMPLE for data

From	Pavel Machek <pavel@ucw.cz>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 09/29] x86: assembly, use DATA_SIMPLE for data
Date	2017-04-27 14:00 +0200
Message-ID	<tAQfv-8w0-15@gated-at.bofh.it> (permalink)
References	<tyHzH-6Pl-7@gated-at.bofh.it> <tyHJo-6SD-31@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi!

> @@ -91,11 +91,11 @@ ENDPROC(do_suspend_lowlevel)
>  
>  .data
>  ALIGN
> -ENTRY(saved_magic)	.long	0
> -ENTRY(saved_eip)	.long	0
> +SYM_DATA_SIMPLE(saved_magic, .long 0)
> +SYM_DATA_SIMPLE_LOCAL(saved_eip, .long 0)
>  
>  # saved registers
> -saved_idt:	.long	0,0
> -saved_ldt:	.long	0
> -saved_tss:	.long	0
> +SYM_DATA_SIMPLE_LOCAL(saved_idt, .long 0,0)
> +SYM_DATA_SIMPLE_LOCAL(saved_ldt, .long 0)
> +SYM_DATA_SIMPLE_LOCAL(saved_tss, .long 0)

Do we really need to mark local data like that? It complicates the
source code a bit...
								Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v3 09/29] x86: assembly, use DATA_SIMPLE for data Pavel Machek <pavel@ucw.cz> - 2017-04-27 14:00 +0200
  Re: [PATCH v3 09/29] x86: assembly, use DATA_SIMPLE for data Jiri Slaby <jslaby@suse.cz> - 2017-04-27 14:40 +0200
    Re: [PATCH v3 09/29] x86: assembly, use DATA_SIMPLE for data Pavel Machek <pavel@ucw.cz> - 2017-04-27 14:50 +0200

csiph-web