Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1631724 > unrolled thread
| Started by | Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
|---|---|
| First post | 2017-04-26 23:00 +0200 |
| Last post | 2017-04-26 23:00 +0200 |
| Articles | 1 — 1 participant |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH] usb: host: xhci: remove #ifdef around PM functions Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-04-26 23:00 +0200
| From | Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
|---|---|
| Date | 2017-04-26 23:00 +0200 |
| Subject | Re: [PATCH] usb: host: xhci: remove #ifdef around PM functions |
| Message-ID | <tACcy-7k3-7@gated-at.bofh.it> |
On Fri, Apr 21, 2017 at 11:42:54PM +0200, Arnd Bergmann wrote:
> The #ifdef is slightly wrong as it doesn't cover the xhci_priv_resume_quirk()
> function, causing a harmless warning:
>
> drivers/usb/host/xhci-plat.c:58:12: error: 'xhci_priv_resume_quirk' defined but not used [-Werror=unused-function]
> static int xhci_priv_resume_quirk(struct usb_hcd *hcd)
>
> A simpler way to do this correctly is to use __maybe_unused annotations
> that let the compiler silently drop the functions when there is no
> reference.
>
> Fixes: b0c69b4bace3 ("usb: host: plat: Enable xHCI plat runtime PM")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/usb/host/xhci-plat.c | 12 ++++--------
> drivers/usb/host/xhci.h | 5 -----
> 2 files changed, 4 insertions(+), 13 deletions(-)
Now applied, thanks.
greg k-h
Back to top | Article view | linux.kernel
csiph-web