Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1631724

Re: [PATCH] usb: host: xhci: remove #ifdef around PM functions

Show all headers | View raw

On Fri, Apr 21, 2017 at 11:42:54PM +0200, Arnd Bergmann wrote:
> The #ifdef is slightly wrong as it doesn't cover the xhci_priv_resume_quirk()
> function, causing a harmless warning:
> 
> drivers/usb/host/xhci-plat.c:58:12: error: 'xhci_priv_resume_quirk' defined but not used [-Werror=unused-function]
>  static int xhci_priv_resume_quirk(struct usb_hcd *hcd)
> 
> A simpler way to do this correctly is to use __maybe_unused annotations
> that let the compiler silently drop the functions when there is no
> reference.
> 
> Fixes: b0c69b4bace3 ("usb: host: plat: Enable xHCI plat runtime PM")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  drivers/usb/host/xhci-plat.c | 12 ++++--------
>  drivers/usb/host/xhci.h      |  5 -----
>  2 files changed, 4 insertions(+), 13 deletions(-)

Now applied, thanks.

greg k-h

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] usb: host: xhci: remove #ifdef around PM functions Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-04-26 23:00 +0200

csiph-web