Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1629294 > unrolled thread
| Started by | Pan Bian <bianpan2016@163.com> |
|---|---|
| First post | 2017-04-24 10:30 +0200 |
| Last post | 2017-05-01 13:40 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH 1/1] power: Fix unchecked return value of devm_kzalloc Pan Bian <bianpan2016@163.com> - 2017-04-24 10:30 +0200
Re: [PATCH 1/1] power: Fix unchecked return value of devm_kzalloc Pali Rohár <pali.rohar@gmail.com> - 2017-04-25 13:00 +0200
Re: [PATCH 1/1] power: Fix unchecked return value of devm_kzalloc Sebastian Reichel <sebastian.reichel@collabora.co.uk> - 2017-05-01 13:40 +0200
| From | Pan Bian <bianpan2016@163.com> |
|---|---|
| Date | 2017-04-24 10:30 +0200 |
| Subject | [PATCH 1/1] power: Fix unchecked return value of devm_kzalloc |
| Message-ID | <tzHxD-4Ds-11@gated-at.bofh.it> |
Function devm_kzalloc() will return a NULL pointer. However, in function
isp1704_charger_probe(), the return value of devm_kzalloc() is directly
used without validation. This may result in a bad memory access bug.
Signed-off-by: Pan Bian <bianpan2016@163.com>
---
drivers/power/supply/isp1704_charger.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/power/supply/isp1704_charger.c b/drivers/power/supply/isp1704_charger.c
index 4cd6899..95af5f3 100644
--- a/drivers/power/supply/isp1704_charger.c
+++ b/drivers/power/supply/isp1704_charger.c
@@ -418,6 +418,10 @@ static int isp1704_charger_probe(struct platform_device *pdev)
pdata = devm_kzalloc(&pdev->dev,
sizeof(struct isp1704_charger_data), GFP_KERNEL);
+ if (!pdata) {
+ ret = -ENOMEM;
+ goto fail0;
+ }
pdata->enable_gpio = gpio;
dev_info(&pdev->dev, "init gpio %d\n", pdata->enable_gpio);
--
1.9.1
[toc] | [next] | [standalone]
| From | Pali Rohár <pali.rohar@gmail.com> |
|---|---|
| Date | 2017-04-25 13:00 +0200 |
| Message-ID | <tA6mm-3Ce-11@gated-at.bofh.it> |
| In reply to | #1629294 |
On Monday 24 April 2017 16:22:08 Pan Bian wrote:
> Function devm_kzalloc() will return a NULL pointer. However, in function
> isp1704_charger_probe(), the return value of devm_kzalloc() is directly
> used without validation. This may result in a bad memory access bug.
>
> Signed-off-by: Pan Bian <bianpan2016@163.com>
> ---
> drivers/power/supply/isp1704_charger.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/power/supply/isp1704_charger.c b/drivers/power/supply/isp1704_charger.c
> index 4cd6899..95af5f3 100644
> --- a/drivers/power/supply/isp1704_charger.c
> +++ b/drivers/power/supply/isp1704_charger.c
> @@ -418,6 +418,10 @@ static int isp1704_charger_probe(struct platform_device *pdev)
>
> pdata = devm_kzalloc(&pdev->dev,
> sizeof(struct isp1704_charger_data), GFP_KERNEL);
> + if (!pdata) {
> + ret = -ENOMEM;
> + goto fail0;
> + }
> pdata->enable_gpio = gpio;
>
> dev_info(&pdev->dev, "init gpio %d\n", pdata->enable_gpio);
Looks good now. Reviewed-by: Pali Rohár <pali.rohar@gmail.com>
--
Pali Rohár
pali.rohar@gmail.com
[toc] | [prev] | [next] | [standalone]
| From | Sebastian Reichel <sebastian.reichel@collabora.co.uk> |
|---|---|
| Date | 2017-05-01 13:40 +0200 |
| Message-ID | <tChQm-8m-25@gated-at.bofh.it> |
| In reply to | #1629294 |
[Multipart message — attachments visible in raw view] — view raw
Hi, On Mon, Apr 24, 2017 at 04:22:08PM +0800, Pan Bian wrote: > Function devm_kzalloc() will return a NULL pointer. However, in function > isp1704_charger_probe(), the return value of devm_kzalloc() is directly > used without validation. This may result in a bad memory access bug. > > Signed-off-by: Pan Bian <bianpan2016@163.com> Thanks, queued. -- Sebastian
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web