Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1630399

Re: [PATCH 1/1] power: Fix unchecked return value of devm_kzalloc

Show all headers | View raw

On Monday 24 April 2017 16:22:08 Pan Bian wrote:
> Function devm_kzalloc() will return a NULL pointer. However, in function
> isp1704_charger_probe(), the return value of devm_kzalloc() is directly
> used without validation. This may result in a bad memory access bug.
> 
> Signed-off-by: Pan Bian <bianpan2016@163.com>
> ---
>  drivers/power/supply/isp1704_charger.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/power/supply/isp1704_charger.c b/drivers/power/supply/isp1704_charger.c
> index 4cd6899..95af5f3 100644
> --- a/drivers/power/supply/isp1704_charger.c
> +++ b/drivers/power/supply/isp1704_charger.c
> @@ -418,6 +418,10 @@ static int isp1704_charger_probe(struct platform_device *pdev)
>  
>  		pdata = devm_kzalloc(&pdev->dev,
>  			sizeof(struct isp1704_charger_data), GFP_KERNEL);
> +		if (!pdata) {
> +			ret = -ENOMEM;
> +			goto fail0;
> +		}
>  		pdata->enable_gpio = gpio;
>  
>  		dev_info(&pdev->dev, "init gpio %d\n", pdata->enable_gpio);

Looks good now. Reviewed-by: Pali Rohár <pali.rohar@gmail.com>

-- 
Pali Rohár
pali.rohar@gmail.com

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/1] power: Fix unchecked return value of devm_kzalloc Pan Bian <bianpan2016@163.com> - 2017-04-24 10:30 +0200
  Re: [PATCH 1/1] power: Fix unchecked return value of devm_kzalloc Pali Rohár <pali.rohar@gmail.com> - 2017-04-25 13:00 +0200
  Re: [PATCH 1/1] power: Fix unchecked return value of devm_kzalloc Sebastian Reichel <sebastian.reichel@collabora.co.uk> - 2017-05-01 13:40 +0200

csiph-web