Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1572351 > unrolled thread

[PATCH] x86: Clean up a tiny description mistake in kernel ld script

Back to article view | Back to linux.kernel

Contents

  [PATCH] x86: Clean up a tiny description mistake in kernel ld script Baoquan He <bhe@redhat.com> - 2017-02-02 14:30 +0100
    Re: [PATCH] x86: Clean up a tiny description mistake in kernel ld  script Thomas Gleixner <tglx@linutronix.de> - 2017-02-10 12:50 +0100
      [PATCH v2] x86: Clean up a tiny description mistake in kernel ld  script Baoquan He <bhe@redhat.com> - 2017-02-10 14:30 +0100
      Re: [PATCH] x86: Clean up a tiny description mistake in kernel ld  script Baoquan He <bhe@redhat.com> - 2017-02-10 18:00 +0100

#1572351 — [PATCH] x86: Clean up a tiny description mistake in kernel ld script

Remove the redundent word "is".

Signed-off-by: Baoquan He <bhe@redhat.com>
---
 arch/x86/kernel/vmlinux.lds.S | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/x86/kernel/vmlinux.lds.S b/arch/x86/kernel/vmlinux.lds.S
index e79f15f..f8f56b9 100644
--- a/arch/x86/kernel/vmlinux.lds.S
+++ b/arch/x86/kernel/vmlinux.lds.S
@@ -8,8 +8,8 @@
  *
  *
  * Don't define absolute symbols until and unless you know that symbol
- * value is should remain constant even if kernel image is relocated
- * at run time. Absolute symbols are not relocated. If symbol value should
+ * value should remain constant even if kernel image is relocated at
+ * run time. Absolute symbols are not relocated. If symbol value should
  * change if kernel is relocated, make the symbol section relative and
  * put it inside the section definition.
  */
-- 
2.5.5

[toc] | [next] | [standalone]

#1578412 — Re: [PATCH] x86: Clean up a tiny description mistake in kernel ld script

On Thu, 2 Feb 2017, Baoquan He wrote:

> Remove the redundent word "is".
> 
> Signed-off-by: Baoquan He <bhe@redhat.com>
> ---
>  arch/x86/kernel/vmlinux.lds.S | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/x86/kernel/vmlinux.lds.S b/arch/x86/kernel/vmlinux.lds.S
> index e79f15f..f8f56b9 100644
> --- a/arch/x86/kernel/vmlinux.lds.S
> +++ b/arch/x86/kernel/vmlinux.lds.S
> @@ -8,8 +8,8 @@
>   *
>   *
>   * Don't define absolute symbols until and unless you know that symbol
> - * value is should remain constant even if kernel image is relocated
> - * at run time. Absolute symbols are not relocated. If symbol value should
> + * value should remain constant even if kernel image is relocated at

And while at it we could make it a proper sentence:

  ... you know that the symbol value should .... even if the kernel ....

> + * run time. Absolute symbols are not relocated. If symbol value should

If the symbol value ... 

>   * change if kernel is relocated, make the symbol section relative and

if the kernel 

>   * put it inside the section definition.
>   */
> -- 
> 2.5.5
> 
> 

[toc] | [prev] | [next] | [standalone]

#1578451 — [PATCH v2] x86: Clean up a tiny description mistake in kernel ld script

Remove the redundent word "is". And add several missing definite
article 'the'.

Signed-off-by: Baoquan He <bhe@redhat.com>
---
 arch/x86/kernel/vmlinux.lds.S | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/x86/kernel/vmlinux.lds.S b/arch/x86/kernel/vmlinux.lds.S
index e79f15f..44d7eaa 100644
--- a/arch/x86/kernel/vmlinux.lds.S
+++ b/arch/x86/kernel/vmlinux.lds.S
@@ -7,10 +7,10 @@
  *   Copyright (C) 2007-2009  Sam Ravnborg <sam@ravnborg.org>
  *
  *
- * Don't define absolute symbols until and unless you know that symbol
- * value is should remain constant even if kernel image is relocated
- * at run time. Absolute symbols are not relocated. If symbol value should
- * change if kernel is relocated, make the symbol section relative and
+ * Don't define absolute symbols until and unless you know that the symbol
+ * value should remain constant even if the kernel image is relocated at
+ * run time. Absolute symbols are not relocated. If the symbol value should
+ * change if the kernel is relocated, make the symbol section relative and
  * put it inside the section definition.
  */
 
-- 
2.5.5

[toc] | [prev] | [next] | [standalone]

#1578615 — Re: [PATCH] x86: Clean up a tiny description mistake in kernel ld script

On 02/10/17 at 12:46pm, Thomas Gleixner wrote:
> On Thu, 2 Feb 2017, Baoquan He wrote:
> 
> > Remove the redundent word "is".
> > 
> > Signed-off-by: Baoquan He <bhe@redhat.com>
> > ---
> >  arch/x86/kernel/vmlinux.lds.S | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/arch/x86/kernel/vmlinux.lds.S b/arch/x86/kernel/vmlinux.lds.S
> > index e79f15f..f8f56b9 100644
> > --- a/arch/x86/kernel/vmlinux.lds.S
> > +++ b/arch/x86/kernel/vmlinux.lds.S
> > @@ -8,8 +8,8 @@
> >   *
> >   *
> >   * Don't define absolute symbols until and unless you know that symbol
> > - * value is should remain constant even if kernel image is relocated
> > - * at run time. Absolute symbols are not relocated. If symbol value should
> > + * value should remain constant even if kernel image is relocated at
> 
> And while at it we could make it a proper sentence:
> 
>   ... you know that the symbol value should .... even if the kernel ....
> 
> > + * run time. Absolute symbols are not relocated. If symbol value should
> 
> If the symbol value ... 
> 
> >   * change if kernel is relocated, make the symbol section relative and
> 
> if the kernel 

Yes, I missed these, let me post v2. Thanks!

> 
> >   * put it inside the section definition.
> >   */
> > -- 
> > 2.5.5
> > 
> > 

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web