Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1578412

Re: [PATCH] x86: Clean up a tiny description mistake in kernel ld script

Show all headers | View raw

On Thu, 2 Feb 2017, Baoquan He wrote:

> Remove the redundent word "is".
> 
> Signed-off-by: Baoquan He <bhe@redhat.com>
> ---
>  arch/x86/kernel/vmlinux.lds.S | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/x86/kernel/vmlinux.lds.S b/arch/x86/kernel/vmlinux.lds.S
> index e79f15f..f8f56b9 100644
> --- a/arch/x86/kernel/vmlinux.lds.S
> +++ b/arch/x86/kernel/vmlinux.lds.S
> @@ -8,8 +8,8 @@
>   *
>   *
>   * Don't define absolute symbols until and unless you know that symbol
> - * value is should remain constant even if kernel image is relocated
> - * at run time. Absolute symbols are not relocated. If symbol value should
> + * value should remain constant even if kernel image is relocated at

And while at it we could make it a proper sentence:

  ... you know that the symbol value should .... even if the kernel ....

> + * run time. Absolute symbols are not relocated. If symbol value should

If the symbol value ... 

>   * change if kernel is relocated, make the symbol section relative and

if the kernel 

>   * put it inside the section definition.
>   */
> -- 
> 2.5.5
> 
> 

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] x86: Clean up a tiny description mistake in kernel ld script Baoquan He <bhe@redhat.com> - 2017-02-02 14:30 +0100
  Re: [PATCH] x86: Clean up a tiny description mistake in kernel ld  script Thomas Gleixner <tglx@linutronix.de> - 2017-02-10 12:50 +0100
    [PATCH v2] x86: Clean up a tiny description mistake in kernel ld  script Baoquan He <bhe@redhat.com> - 2017-02-10 14:30 +0100
    Re: [PATCH] x86: Clean up a tiny description mistake in kernel ld  script Baoquan He <bhe@redhat.com> - 2017-02-10 18:00 +0100

csiph-web