Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1577712 > unrolled thread

[PATCH -next] x86/intel_rdt: Remove duplicated include from intel_rdt_rdtgroup.c

Started byWei Yongjun <weiyj.lk@gmail.com>
First post2017-02-09 16:40 +0100
Last post2017-02-10 10:00 +0100
Articles 2 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH -next] x86/intel_rdt: Remove duplicated include from intel_rdt_rdtgroup.c Wei Yongjun <weiyj.lk@gmail.com> - 2017-02-09 16:40 +0100
    Re: [PATCH -next] x86/intel_rdt: Remove duplicated include from  intel_rdt_rdtgroup.c Ingo Molnar <mingo@kernel.org> - 2017-02-10 10:00 +0100

#1577712 — [PATCH -next] x86/intel_rdt: Remove duplicated include from intel_rdt_rdtgroup.c

FromWei Yongjun <weiyj.lk@gmail.com>
Date2017-02-09 16:40 +0100
Subject[PATCH -next] x86/intel_rdt: Remove duplicated include from intel_rdt_rdtgroup.c
Message-ID<t8YZd-7Tl-43@gated-at.bofh.it>
From: Wei Yongjun <weiyongjun1@huawei.com>

Remove duplicated include.

Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
 arch/x86/kernel/cpu/intel_rdt_rdtgroup.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/x86/kernel/cpu/intel_rdt_rdtgroup.c b/arch/x86/kernel/cpu/intel_rdt_rdtgroup.c
index 8af04af..759577d 100644
--- a/arch/x86/kernel/cpu/intel_rdt_rdtgroup.c
+++ b/arch/x86/kernel/cpu/intel_rdt_rdtgroup.c
@@ -27,7 +27,6 @@
 #include <linux/seq_file.h>
 #include <linux/sched.h>
 #include <linux/slab.h>
-#include <linux/cpu.h>
 #include <linux/task_work.h>
 
 #include <uapi/linux/magic.h>

[toc] | [next] | [standalone]


#1578307 — Re: [PATCH -next] x86/intel_rdt: Remove duplicated include from intel_rdt_rdtgroup.c

FromIngo Molnar <mingo@kernel.org>
Date2017-02-10 10:00 +0100
SubjectRe: [PATCH -next] x86/intel_rdt: Remove duplicated include from intel_rdt_rdtgroup.c
Message-ID<t9fdD-17p-11@gated-at.bofh.it>
In reply to#1577712
* Wei Yongjun <weiyj.lk@gmail.com> wrote:

> From: Wei Yongjun <weiyongjun1@huawei.com>
> 
> Remove duplicated include.
> 
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
>  arch/x86/kernel/cpu/intel_rdt_rdtgroup.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/x86/kernel/cpu/intel_rdt_rdtgroup.c b/arch/x86/kernel/cpu/intel_rdt_rdtgroup.c
> index 8af04af..759577d 100644
> --- a/arch/x86/kernel/cpu/intel_rdt_rdtgroup.c
> +++ b/arch/x86/kernel/cpu/intel_rdt_rdtgroup.c
> @@ -27,7 +27,6 @@
>  #include <linux/seq_file.h>
>  #include <linux/sched.h>
>  #include <linux/slab.h>
> -#include <linux/cpu.h>
>  #include <linux/task_work.h>
>  
>  #include <uapi/linux/magic.h>

Same comment as for your other trivial patch: the list of includes in that .c file 
can probably be further reduced.

I.e. instead of a mindless single liner that helps no-one, try to improve the code 
for real.

Thanks,

	Ingo

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web