Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1578307

Re: [PATCH -next] x86/intel_rdt: Remove duplicated include from intel_rdt_rdtgroup.c

Show all headers | View raw

* Wei Yongjun <weiyj.lk@gmail.com> wrote:

> From: Wei Yongjun <weiyongjun1@huawei.com>
> 
> Remove duplicated include.
> 
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
>  arch/x86/kernel/cpu/intel_rdt_rdtgroup.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/x86/kernel/cpu/intel_rdt_rdtgroup.c b/arch/x86/kernel/cpu/intel_rdt_rdtgroup.c
> index 8af04af..759577d 100644
> --- a/arch/x86/kernel/cpu/intel_rdt_rdtgroup.c
> +++ b/arch/x86/kernel/cpu/intel_rdt_rdtgroup.c
> @@ -27,7 +27,6 @@
>  #include <linux/seq_file.h>
>  #include <linux/sched.h>
>  #include <linux/slab.h>
> -#include <linux/cpu.h>
>  #include <linux/task_work.h>
>  
>  #include <uapi/linux/magic.h>

Same comment as for your other trivial patch: the list of includes in that .c file 
can probably be further reduced.

I.e. instead of a mindless single liner that helps no-one, try to improve the code 
for real.

Thanks,

	Ingo

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH -next] x86/intel_rdt: Remove duplicated include from intel_rdt_rdtgroup.c Wei Yongjun <weiyj.lk@gmail.com> - 2017-02-09 16:40 +0100
  Re: [PATCH -next] x86/intel_rdt: Remove duplicated include from  intel_rdt_rdtgroup.c Ingo Molnar <mingo@kernel.org> - 2017-02-10 10:00 +0100

csiph-web