Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1576050 > unrolled thread

Re: [PATCH] kvm: vmx: Use the hardware provided GPA instead of page walk

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH] kvm: vmx: Use the hardware provided GPA instead of page  walk Radim Krčmář <rkrcmar@redhat.com> - 2017-02-07 22:00 +0100
    Re: [PATCH] kvm: vmx: Use the hardware provided GPA instead of page  walk Paolo Bonzini <pbonzini@redhat.com> - 2017-02-08 09:20 +0100

#1576050 — Re: [PATCH] kvm: vmx: Use the hardware provided GPA instead of page walk

2017-01-27 19:34+0100, Paolo Bonzini:
> As in the SVM patch, the guest physical address is passed by
> VMX to x86_emulate_instruction already, so mark the GPA as available
> in vcpu->arch.
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---

In line with the SVM patch,

Reviewed-by: Radim Krčmář <rkrcmar@redhat.com>

Still, I don't see why we need a variable that is touched on every VM
exit.  Is this a mere shortcut to propagating the gpa_available bit with
the gpa argument to kvm_mmu_page_fault() and x86_emulate_instruction()?

Thanks.

[toc] | [next] | [standalone]

#1576326

On 07/02/2017 21:52, Radim Krčmář wrote:
> 2017-01-27 19:34+0100, Paolo Bonzini:
>> As in the SVM patch, the guest physical address is passed by
>> VMX to x86_emulate_instruction already, so mark the GPA as available
>> in vcpu->arch.
>>
>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>> ---
> 
> In line with the SVM patch,
> 
> Reviewed-by: Radim Krčmář <rkrcmar@redhat.com>
> 
> Still, I don't see why we need a variable that is touched on every VM
> exit.  Is this a mere shortcut to propagating the gpa_available bit with
> the gpa argument to kvm_mmu_page_fault() and x86_emulate_instruction()?

Yes, pretty much.

Paolo

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web